Merge pull request #1152 from cloudbees-oss/nit-updates

Improvement

Author: Konboi

.github/workflows/test.yml

@@ -82,7 +82,7 @@ jobs:
 
           function record() {
             # Record test results
-            SMART_TESTS_SLACK_NOTIFICATION=true smart-tests record test file  --session $(cat session.txt) test-results/*.xml
+            SMART_TESTS_SLACK_NOTIFICATION=true smart-tests record tests file  --session $(cat session.txt) test-results/*.xml
           }
 
           trap record EXIT

README.md

@@ -1,7 +1,7 @@
 # Usage
 
-See https://www.launchableinc.com/docs/resources/cli-reference/ and
-https://www.launchableinc.com/docs/getting-started/.
+See https://help.launchableinc.com/resources/cli-reference/ and
+https://help.launchableinc.com/sending-data-to-launchable/using-the-launchable-cli/getting-started/.
 
 # Development
 
@@ -82,7 +82,7 @@ uv run poe install
 # Add runtime dependency
 uv add some-package
 
-# Add development dependency  
+# Add development dependency
 uv add --dev some-dev-package
 ```
 

pyproject.toml

@@ -1,25 +1,23 @@
 [project]
 name = "smart-tests-cli"
-authors = [
-    {name = "CloudBees", email = "[email protected]"}
-]
+authors = [{ name = "CloudBees", email = "[email protected]" }]
 description = "Smart Tests CLI"
 readme = "README.md"
-license = {text = "Apache Software License v2"}
+license = { text = "Apache Software License v2" }
 requires-python = ">=3.13"
 classifiers = [
     "Programming Language :: Python :: 3",
     "License :: OSI Approved :: Apache Software License",
     "Operating System :: OS Independent",
 ]
 dependencies = [
-    "typer>=0.9.0",
-    "requests>=2.25",
-    "urllib3>=1.26",
+    "typer>=0.19.1",
+    "requests>=2.32.5",
+    "urllib3>=2.5",
     "junitparser>=4.0.0",
     "more-itertools>=7.1.0",
-    "python-dateutil",
-    "tabulate",
+    "python-dateutil>=2.9",
+    "tabulate>=0.9",
 ]
 dynamic = ["version"]
 
@@ -37,7 +35,7 @@ dev-dependencies = [
     "mypy",
     "pre-commit",
     "responses",
-    "types-pkg_resources",
+    "types-setuptools",
     "types-python-dateutil",
     "types-requests",
     "types-tabulate",

smart_tests/__main__.py

@@ -157,8 +157,8 @@ def main(
     app.add_typer(detect_flakes_target_app, name="detect-flakes")
 
     # Add record-target as a sub-app to record command
-    record.app.add_typer(record_target_app, name="test")  # Use NestedCommand version
-    record.app.add_typer(record_target_app, name="tests")  # Alias for backward compatibility
+    record.app.add_typer(record_target_app, name="tests")
+
 except Exception as e:
     logging.warning(f"Failed to use NestedCommand apps at init: {e}")
     # Fallback to original structure

smart_tests/commands/record/session.py

@@ -32,7 +32,6 @@ def session(
         help="Set test suite name. A test suite is a collection of test sessions. Setting a test suite allows you to "
              "manage data over test sessions and lineages."
     )],
-    print_session: bool = True,
     flavors: Annotated[List[KeyValue], typer.Option(
         "--flavor",
         help="flavors",

smart_tests/commands/record/tests.py

@@ -155,7 +155,7 @@ class RecordTests:
         # A common mechanism to build ParseFunc by building JUnit XML report in-memory (or build it the usual way
         # and patch it to fix things up). This is handy as some libraries
         # produce invalid / broken JUnit reports
-        JUnitXmlParseFunc = Callable[[str], ET.Element]
+        JUnitXmlParseFunc = Callable[[str], ET.Element | ET.ElementTree]
 
         @property
         def path_builder(self) -> CaseEvent.TestPathBuilder:

smart_tests/commands/subset.py

@@ -438,7 +438,7 @@ def run(self):
                     print_error_and_die("ERROR: Given arguments did not match any tests. They appear to be incorrect/non-existent.", tracking_client, Tracking.ErrorEvent.USER_ERROR)  # noqa E501
                 else:
                     print_error_and_die(
-                        "ERROR: Expecting tests to be given, but none provided. See https://www.launchableinc.com/docs/features/predictive-test-selection/requesting-and-running-a-subset-of-tests/subsetting-with-the-launchable-cli/ and provide ones, or use the `--get-tests-from-previous-sessions` option",  # noqa E501
+                        "ERROR: Expecting tests to be given, but none provided. See https://help.launchableinc.com/features/predictive-test-selection/requesting-and-running-a-subset-of-tests/ and provide ones, or use the `--get-tests-from-previous-sessions` option",  # noqa E501
                         tracking_client,
                         Tracking.ErrorEvent.USER_ERROR)
 

smart_tests/commands/verify.py

@@ -63,7 +63,7 @@ def check_java_version(javacmd: str) -> int:
 def verify(ctx: typer.Context):
     # Run the verification (no subcommands in this app)
     # In this command, regardless of REPORT_ERROR_KEY, always report an unexpected error with full stack trace
-    # to assist troubleshooting. `click.UsageError` is handled by the invoking
+    # to assist troubleshooting. `typer.BadParameter` is handled by the invoking
     # Click gracefully.
 
     app_instance = ctx.obj

smart_tests/test_runners/behave.py

@@ -1,5 +1,5 @@
 import os
-from typing import Annotated, List
+from typing import Annotated, List, cast
 from xml.etree import ElementTree as ET
 
 import typer
@@ -18,7 +18,7 @@ def record_tests(
         client.report(r)
 
     def parse_func(p: str) -> ET.ElementTree:
-        tree = ET.parse(p)
+        tree = cast(ET.ElementTree, ET.parse(p))
         for suite in tree.iter("testsuite"):
             if len(suite) == 0:
                 continue

smart_tests/test_runners/cucumber.py

@@ -5,7 +5,7 @@
 from copy import deepcopy
 from enum import Enum
 from pathlib import Path
-from typing import Annotated, Dict, Generator, List
+from typing import Annotated, Dict, Generator, List, cast
 from xml.etree import ElementTree as ET
 
 import typer
@@ -41,7 +41,7 @@ def record_tests(
         _record_tests_from_xml(client, reports, report_file_and_test_file_map)
 
         def parse_func(report: str) -> ET.ElementTree:
-            tree = ET.parse(report)
+            tree = cast(ET.ElementTree, ET.parse(report))
             for case in tree.findall("testcase"):
                 case.attrib["file"] = str(report_file_and_test_file_map[report])