Skip to content

Commit ebff137

Browse files
committed
remove url from Timezone, replace wildcard import
1 parent 662368c commit ebff137

File tree

3 files changed

+42
-16
lines changed

3 files changed

+42
-16
lines changed

src/main/java/org/zendesk/client/v2/Zendesk.java

Lines changed: 38 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,44 @@
2121
import org.asynchttpclient.request.body.multipart.StringPart;
2222
import org.slf4j.Logger;
2323
import org.slf4j.LoggerFactory;
24-
import org.zendesk.client.v2.model.*;
24+
import org.zendesk.client.v2.model.AgentRole;
25+
import org.zendesk.client.v2.model.Attachment;
26+
import org.zendesk.client.v2.model.Audit;
27+
import org.zendesk.client.v2.model.Automation;
28+
import org.zendesk.client.v2.model.Brand;
29+
import org.zendesk.client.v2.model.Comment;
30+
import org.zendesk.client.v2.model.ComplianceDeletionStatus;
31+
import org.zendesk.client.v2.model.DeletedTicket;
32+
import org.zendesk.client.v2.model.Field;
33+
import org.zendesk.client.v2.model.Forum;
34+
import org.zendesk.client.v2.model.Group;
35+
import org.zendesk.client.v2.model.GroupMembership;
36+
import org.zendesk.client.v2.model.Identity;
37+
import org.zendesk.client.v2.model.JobStatus;
38+
import org.zendesk.client.v2.model.Macro;
39+
import org.zendesk.client.v2.model.Metric;
40+
import org.zendesk.client.v2.model.Organization;
41+
import org.zendesk.client.v2.model.OrganizationField;
42+
import org.zendesk.client.v2.model.OrganizationMembership;
43+
import org.zendesk.client.v2.model.SatisfactionRating;
44+
import org.zendesk.client.v2.model.SearchResultEntity;
45+
import org.zendesk.client.v2.model.SortOrder;
46+
import org.zendesk.client.v2.model.Status;
47+
import org.zendesk.client.v2.model.SuspendedTicket;
48+
import org.zendesk.client.v2.model.Ticket;
49+
import org.zendesk.client.v2.model.TicketCount;
50+
import org.zendesk.client.v2.model.TicketForm;
51+
import org.zendesk.client.v2.model.TicketImport;
52+
import org.zendesk.client.v2.model.TicketPage;
53+
import org.zendesk.client.v2.model.TicketResult;
54+
import org.zendesk.client.v2.model.TimeZone;
55+
import org.zendesk.client.v2.model.Topic;
56+
import org.zendesk.client.v2.model.Trigger;
57+
import org.zendesk.client.v2.model.TwitterMonitor;
58+
import org.zendesk.client.v2.model.User;
59+
import org.zendesk.client.v2.model.UserField;
60+
import org.zendesk.client.v2.model.UserRelatedInfo;
61+
import org.zendesk.client.v2.model.View;
2562
import org.zendesk.client.v2.model.dynamic.DynamicContentItem;
2663
import org.zendesk.client.v2.model.dynamic.DynamicContentItemVariant;
2764
import org.zendesk.client.v2.model.hc.Article;

src/main/java/org/zendesk/client/v2/model/TimeZone.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ public class TimeZone {
1313
private String translatedName;
1414
private String name;
1515
private String ianaName;
16-
private String url;
1716
private int offset;
1817
private String formattedOffset;
1918

@@ -43,14 +42,6 @@ public void setIanaName(String ianaName) {
4342
this.ianaName = ianaName;
4443
}
4544

46-
public String getUrl() {
47-
return url;
48-
}
49-
50-
public void setUrl(String url) {
51-
this.url = url;
52-
}
53-
5445
public int getOffset() {
5546
return offset;
5647
}
@@ -75,11 +66,11 @@ public boolean equals(Object o) {
7566
TimeZone timeZone = (TimeZone) o;
7667
return offset == timeZone.offset && Objects.equals(translatedName, timeZone.translatedName) &&
7768
Objects.equals(name, timeZone.name) && Objects.equals(ianaName, timeZone.ianaName) &&
78-
Objects.equals(url, timeZone.url) && Objects.equals(formattedOffset, timeZone.formattedOffset);
69+
Objects.equals(formattedOffset, timeZone.formattedOffset);
7970
}
8071

8172
@Override
8273
public int hashCode() {
83-
return Objects.hash(translatedName, name, ianaName, url, offset, formattedOffset);
74+
return Objects.hash(translatedName, name, ianaName, offset, formattedOffset);
8475
}
8576
}

src/test/java/org/zendesk/client/v2/model/TimeZoneTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ public class TimeZoneTest {
3232

3333
@Rule
3434
public WireMockClassRule zendeskApiMock = zendeskApiClass;
35-
private final int ephemeralPort = zendeskApiMock.port();
36-
private final String hostname = String.format(MOCK_URL_FORMATTED_STRING, ephemeralPort);
3735

3836
private Zendesk client;
3937
private final ObjectMapper objectMapper = Zendesk.createMapper();
4038

4139
@Before
4240
public void setUp() {
41+
int ephemeralPort = zendeskApiMock.port();
42+
String hostname = String.format(MOCK_URL_FORMATTED_STRING, ephemeralPort);
4343
client = new Zendesk.Builder(hostname)
4444
.setUsername(MOCK_USERNAME)
4545
.setToken(MOCK_API_TOKEN)
@@ -61,15 +61,13 @@ public void getTimeZones() throws JsonProcessingException {
6161
timeZone1.setTranslatedName("Pacific Time (US & Canada)");
6262
timeZone1.setName("Pacific Time (US & Canada)");
6363
timeZone1.setIanaName("America/Los_Angeles");
64-
timeZone1.setUrl(hostname + "/api/v2/time_zones/Pacific%20Time%20(US%20&%20Canada).json");
6564
timeZone1.setOffset(-420);
6665
timeZone1.setFormattedOffset("GMT-07:00");
6766

6867
TimeZone timeZone2 = new TimeZone();
6968
timeZone1.setTranslatedName("Kyiv");
7069
timeZone1.setName("Kyiv");
7170
timeZone1.setIanaName("Europe/Kiev");
72-
timeZone1.setUrl(hostname + "/api/v2/time_zones/Kyiv.json");
7371
timeZone1.setOffset(180);
7472
timeZone1.setFormattedOffset("GMT+03:00");
7573

0 commit comments

Comments
 (0)