Skip to content

Commit fc46306

Browse files
committed
fix: removed duplicate class variables. type, priority, and customFields were defined both here in Ticket and in it's parent class, Request. The fact that these had different access modifers in each definition led to serialiation/marshalling problems in some libraries (GSON for instance). Relying now on the definition in the parent class and fix is seamless.
1 parent e609033 commit fc46306

File tree

1 file changed

+0
-28
lines changed

1 file changed

+0
-28
lines changed

src/main/java/org/zendesk/client/v2/model/Ticket.java

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ public class Ticket extends Request implements SearchResultEntity {
1616
private static final long serialVersionUID = 1L;
1717

1818
private String externalId;
19-
private Type type;
20-
private Priority priority;
2119
private String recipient;
2220
private Long submitterId;
2321
private Long assigneeId;
@@ -29,7 +27,6 @@ public class Ticket extends Request implements SearchResultEntity {
2927
private boolean hasIncidents;
3028
private Date dueAt;
3129
private List<String> tags;
32-
private List<CustomFieldValue> customFields;
3330
private SatisfactionRating satisfactionRating;
3431
private List<Long> sharingAgreementIds;
3532
private List<Long> followupIds;
@@ -79,15 +76,6 @@ public void setCollaborators(List<Collaborator> collaborators) {
7976
this.collaborators = collaborators;
8077
}
8178

82-
@JsonProperty("custom_fields")
83-
public List<CustomFieldValue> getCustomFields() {
84-
return customFields;
85-
}
86-
87-
public void setCustomFields(List<CustomFieldValue> customFields) {
88-
this.customFields = customFields;
89-
}
90-
9179
@JsonProperty("due_at")
9280
public Date getDueAt() {
9381
return dueAt;
@@ -142,14 +130,6 @@ public void setHasIncidents(boolean hasIncidents) {
142130
this.hasIncidents = hasIncidents;
143131
}
144132

145-
public Priority getPriority() {
146-
return priority;
147-
}
148-
149-
public void setPriority(Priority priority) {
150-
this.priority = priority;
151-
}
152-
153133
@JsonProperty("problem_id")
154134
public Long getProblemId() {
155135
return problemId;
@@ -231,14 +211,6 @@ public void setTicketFormId(Long ticketFormId) {
231211
this.ticketFormId = ticketFormId;
232212
}
233213

234-
public Type getType() {
235-
return type;
236-
}
237-
238-
public void setType(Type type) {
239-
this.type = type;
240-
}
241-
242214
@JsonProperty("is_public")
243215
public Boolean getIsPublic() {
244216
return isPublic;

0 commit comments

Comments
 (0)