Skip to content

Commit daf6ae6

Browse files
authored
Merge pull request #199 from cloudblue/lite-26708_hf_fix_bump_extension
[HF] LITE-26708 Fix bump extension
2 parents 19253db + 3698e6b commit daf6ae6

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

connect/cli/plugins/project/extension/helpers.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,8 @@ def _update_docker_file_runner_from(dockerfile: str, latest_version: str):
184184
for line in f.readlines():
185185
content = line.split()
186186
if (
187-
content[0] == 'FROM'
187+
content
188+
and content[0] == 'FROM'
188189
and content[1].startswith(
189190
'cloudblueconnect/connect-extension-runner:',
190191
)

tests/plugins/project/test_extension_helpers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -703,8 +703,8 @@ def test_bump_runner_version(mocker, capsys):
703703
captured = capsys.readouterr()
704704
assert 'Runner version has been successfully updated to 1.0' in captured.out
705705
assert f'{os.path.join(project_dir, "docker-compose.yml")}' in captured.out
706-
assert f'{os.path.join(project_dir, "OtherDockerfile")}' in captured.out
707-
assert f'{os.path.join(project_dir, "Dockerfile")}' in captured.out
706+
assert 'OtherDockerfile' in captured.out
707+
assert 'Dockerfile' in captured.out
708708

709709

710710
def test_bump_runner_version_no_update_required(mocker, capsys):

0 commit comments

Comments
 (0)