refactor: simplify sensors — remove budget aggregates, options flow, and streamline categories

- Remove 8 budget aggregate sensors: BudgetSummary, TotalBudgeted, TotalSpent,
  BudgetRemaining, BudgetHealth, CategoriesOverBudgetCount,
  CategoriesBudgeted, CategoriesUnbudgeted
- Remove options flow (period/interval settings) and _fetch_budget_summary
  from coordinator — no longer needed
- Strip const.py to just DOMAIN
- Update CategoriesSensor attributes to include budgeted_categories and
  unbudgeted_categories lists
- Simplify category sensor names to just the category title
- Clean up dead code: remove _attr_device_info from binary sensor __init__
  methods, remove unused imports (calendar, non_transfer_budget_packages
  from sensor.py, options constants)

Budget data per category remains available via individual category sensor
attributes (budgeted, actual, remaining, over_by, over_budget,
percentage_used) for users to build custom templates and automations.

Author: cloudbr34k84

custom_components/ha_pocketsmith/binary_sensor.py

@@ -38,7 +38,6 @@ def __init__(self, coordinator: PocketSmithCoordinator) -> None:
         """Initialise the sensor."""
         super().__init__(coordinator)
         self._user_id = coordinator.data["user_id"]
-        self._attr_device_info = _make_device_info(coordinator)
         self._attr_device_class = BinarySensorDeviceClass.PROBLEM
 
     @property
@@ -104,7 +103,6 @@ def __init__(self, coordinator: PocketSmithCoordinator) -> None:
         """Initialise the sensor."""
         super().__init__(coordinator)
         self._user_id = coordinator.data["user_id"]
-        self._attr_device_info = _make_device_info(coordinator)
 
     @property
     def device_info(self):
@@ -161,7 +159,6 @@ def __init__(self, coordinator: PocketSmithCoordinator) -> None:
         """Initialise the sensor."""
         super().__init__(coordinator)
         self._user_id = coordinator.data["user_id"]
-        self._attr_device_info = _make_device_info(coordinator)
         self._attr_device_class = BinarySensorDeviceClass.PROBLEM
 
     @property

custom_components/ha_pocketsmith/config_flow.py

@@ -5,16 +5,9 @@
 import aiohttp
 import voluptuous as vol
 from homeassistant import config_entries
-from homeassistant.core import callback
 from homeassistant.helpers.aiohttp_client import async_get_clientsession
 
-from .const import (
-    DOMAIN,
-    CONF_PERIOD,
-    CONF_INTERVAL,
-    PERIOD_OPTIONS,
-    INTERVAL_OPTIONS,
-)
+from .const import DOMAIN
 
 _LOGGER = logging.getLogger(__name__)
 _API_ME = "https://api.pocketsmith.com/v2/me"
@@ -42,12 +35,6 @@ class PocketSmithConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):
 
     VERSION = 1
 
-    @staticmethod
-    @callback
-    def async_get_options_flow(config_entry):
-        """Create the options flow."""
-        return PocketSmithOptionsFlow()
-
     async def async_step_user(self, user_input=None):
         """Handle the initial setup step."""
         await self.async_set_unique_id(DOMAIN)
@@ -77,27 +64,3 @@ async def async_step_user(self, user_input=None):
             data_schema=vol.Schema({vol.Required("developer_key"): str}),
             errors=errors,
         )
-
-
-OPTIONS_SCHEMA = vol.Schema(
-    {
-        vol.Required(CONF_PERIOD): vol.In(PERIOD_OPTIONS),
-        vol.Required(CONF_INTERVAL): vol.In(INTERVAL_OPTIONS),
-    }
-)
-
-
-class PocketSmithOptionsFlow(config_entries.OptionsFlowWithReload):
-    """Handle PocketSmith options (period and interval)."""
-
-    async def async_step_init(self, user_input=None):
-        """Show the options form."""
-        if user_input is not None:
-            return self.async_create_entry(title="", data=user_input)
-
-        return self.async_show_form(
-            step_id="init",
-            data_schema=self.add_suggested_values_to_schema(
-                OPTIONS_SCHEMA, self.config_entry.options
-            ),
-        )

custom_components/ha_pocketsmith/const.py

@@ -1,12 +1,2 @@
 """Constants for the PocketSmith integration."""
 DOMAIN = "ha_pocketsmith"
-
-DEFAULT_PERIOD = "months"
-DEFAULT_INTERVAL = 1
-DEFAULT_LOOKBACK_MONTHS = 12
-
-CONF_PERIOD = "period"
-CONF_INTERVAL = "interval"
-
-PERIOD_OPTIONS = ["weeks", "months", "years"]
-INTERVAL_OPTIONS = [1, 2, 3, 4]

custom_components/ha_pocketsmith/coordinator.py

@@ -1,7 +1,6 @@
 """DataUpdateCoordinator for PocketSmith."""
 import asyncio
 import logging
-import calendar
 from datetime import date, datetime, timedelta, timezone
 
 import aiohttp
@@ -10,7 +9,7 @@
 from homeassistant.helpers.aiohttp_client import async_get_clientsession
 from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, UpdateFailed
 
-from .const import DOMAIN, CONF_PERIOD, CONF_INTERVAL, DEFAULT_PERIOD, DEFAULT_INTERVAL
+from .const import DOMAIN
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -58,7 +57,6 @@ async def _async_update_data(self) -> dict:
             uncategorised_count = await self._fetch_uncategorised_count(session, user_id)
             categories = await self._fetch_categories(session, user_id)
             budget = await self._fetch_budget(session, user_id)
-            budget_summary = await self._fetch_budget_summary(session, user_id)
         except aiohttp.ClientError as err:
             raise UpdateFailed(
                 "Unable to reach the PocketSmith API. Check your network connection."
@@ -77,7 +75,6 @@ async def _async_update_data(self) -> dict:
             "uncategorised_count": uncategorised_count,
             "categories": categories,
             "budget": budget,
-            "budget_summary": budget_summary,
             "enriched_categories": enriched_categories,
             "forecast_last_updated": datetime.now(timezone.utc),
         }
@@ -369,65 +366,6 @@ async def _fetch_budget(self, session: aiohttp.ClientSession, user_id: int) -> l
         _LOGGER.debug("Fetched budget for user %s", user_id)
         return budget
 
-    async def _fetch_budget_summary(self, session: aiohttp.ClientSession, user_id: int) -> list:
-        """Return budget summary for the given user for the current calendar month."""
-        today = date.today()
-        start_date = today.replace(day=1)
-        end_date = today.replace(day=calendar.monthrange(today.year, today.month)[1])
-        period = self._entry.options.get(CONF_PERIOD, DEFAULT_PERIOD)
-        interval = self._entry.options.get(CONF_INTERVAL, DEFAULT_INTERVAL)
-        url = (
-            "%s/users/%s/budget_summary?period=%s&interval=%s&start_date=%s&end_date=%s&per_page=1000"
-            % (_API_BASE, user_id, period, interval, start_date.isoformat(), end_date.isoformat())
-        )
-
-        async with asyncio.timeout(_REQUEST_TIMEOUT):
-            async with session.get(url, headers=self._headers) as response:
-                if response.status == 400:
-                    try:
-                        error_body = (await response.json()).get("error", "unknown error")
-                    except Exception:
-                        error_body = "unknown error"
-                    raise UpdateFailed(
-                        "PocketSmith returned a bad request error: %s. This may indicate a bug in the integration." % error_body
-                    )
-                if response.status == 401:
-                    raise UpdateFailed(
-                        "PocketSmith authentication failed — your developer key is invalid or has been revoked. "
-                        "Reconfigure the integration to fix this."
-                    )
-                if response.status == 403:
-                    raise UpdateFailed(
-                        "PocketSmith access denied — your developer key lacks the required permissions "
-                        "to read your budget summary."
-                    )
-                if response.status == 404:
-                    raise UpdateFailed(
-                        "PocketSmith could not find your budget summary data. This may be a temporary API issue."
-                    )
-                if response.status == 405:
-                    raise UpdateFailed(
-                        "PocketSmith returned Method Not Allowed (HTTP 405). This is likely a bug in the integration — please report it."
-                    )
-                if response.status == 429:
-                    raise UpdateFailed(
-                        "PocketSmith API rate limit exceeded. The integration will retry on the next update."
-                    )
-                if response.status == 503:
-                    raise UpdateFailed(
-                        "PocketSmith is temporarily unavailable for maintenance (HTTP 503). The integration will retry on the next update."
-                    )
-                if response.status >= 500:
-                    raise UpdateFailed(
-                        "PocketSmith is experiencing server issues (HTTP %s). "
-                        "Data will refresh when the service recovers." % response.status
-                    )
-                response.raise_for_status()
-                budget_summary = await response.json()
-
-        _LOGGER.debug("Fetched budget summary for user %s", user_id)
-        return budget_summary
-
     def _build_enriched_categories(self, categories: list, budget: list) -> list:
         """Return a flat enriched list of all categories with budget data."""