File tree Expand file tree Collapse file tree 1 file changed +10
-7
lines changed Expand file tree Collapse file tree 1 file changed +10
-7
lines changed Original file line number Diff line number Diff line change @@ -188,14 +188,17 @@ export function initRepoIssueCommentDelete() {
188188 const path = conversationHolder . getAttribute ( 'data-path' ) ;
189189 const side = conversationHolder . getAttribute ( 'data-side' ) ;
190190 const idx = conversationHolder . getAttribute ( 'data-idx' ) ;
191- const lineType = conversationHolder . closest ( 'tr' ) . getAttribute ( 'data-line-type' ) ;
192-
193- if ( lineType === 'same' ) {
194- document . querySelector ( `[data-path="${ path } "] .add-code-comment[data-idx="${ idx } "]` ) . classList . remove ( 'tw-invisible' ) ;
195- } else {
196- document . querySelector ( `[data-path="${ path } "] .add-code-comment[data-side="${ side } "][data-idx="${ idx } "]` ) . classList . remove ( 'tw-invisible' ) ;
191+ const lineType = conversationHolder . closest ( 'tr' ) ?. getAttribute ( 'data-line-type' ) ;
192+
193+ // the conversation holder could appear either on the "Conversation" page, or the "Files Changed" page
194+ // on the Conversation page, there is no parent "tr", so no need to do anything for "add-code-comment"
195+ if ( lineType ) {
196+ if ( lineType === 'same' ) {
197+ document . querySelector ( `[data-path="${ path } "] .add-code-comment[data-idx="${ idx } "]` ) . classList . remove ( 'tw-invisible' ) ;
198+ } else {
199+ document . querySelector ( `[data-path="${ path } "] .add-code-comment[data-side="${ side } "][data-idx="${ idx } "]` ) . classList . remove ( 'tw-invisible' ) ;
200+ }
197201 }
198-
199202 conversationHolder . remove ( ) ;
200203 }
201204
You can’t perform that action at this time.
0 commit comments