chore(edward) lint

Author: coderaiser

.github/workflows/nodejs.yml

@@ -1,5 +1,5 @@
 name: Node CI
-'on':
+on:
   - push
   - pull_request
 jobs:
@@ -8,12 +8,12 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - 14.x
           - 16.x
+          - 18.x
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
       - name: Install Redrun

.gitignore

@@ -19,3 +19,4 @@ modules/pako/dist
 yarn-error.log
 
 coverage
+.idea

.putout.json

@@ -1,7 +1,7 @@
 {
     "match": {
         "client": {
-            "declare-undefined-variables": "off"
+            "nodejs": "off"
         },
         "client/edward.js": {
             "remove-console": "off"

README.md

@@ -1,13 +1,11 @@
-# Edward [![License][LicenseIMGURL]][LicenseURL] [![NPM version][NPMIMGURL]][NPMURL] [![Dependency Status][DependencyStatusIMGURL]][DependencyStatusURL]
+# Edward [![License][LicenseIMGURL]][LicenseURL] [![NPM version][NPMIMGURL]][NPMURL]
 
 [NPMIMGURL]: https://img.shields.io/npm/v/edward.svg?style=flat
 [BuildStatusURL]: https://github.com/cloudcmd/edward/actions?query=workflow%3A%22Node+CI%22 "Build Status"
 [BuildStatusIMGURL]: https://github.com/cloudcmd/edward/workflows/Node%20CI/badge.svg
-[DependencyStatusIMGURL]: https://img.shields.io/david/cloudcmd/edward.svg?style=flat
 [LicenseIMGURL]: https://img.shields.io/badge/license-MIT-317BF9.svg?style=flat
 [NPM_INFO_IMG]: https://nodei.co/npm/edward.png?downloads=true&&stars&&downloadRank "npm install edward"
 [NPMURL]: https://npmjs.org/package/edward "npm"
-[DependencyStatusURL]: https://david-dm.org/cloudcmd/edward "Dependency Status"
 [LicenseURL]: https://tldrlegal.com/license/mit-license "MIT License"
 [edit.json]: https://github.com/cloudcmd/edward/tree/master/json/edit.json "edit.json"
 
@@ -28,7 +26,7 @@ Web editor used in [Cloud Commander](http://cloudcmd.io) based on [Ace](http://a
 npm i edward -g
 ```
 
-![NPM_INFO][NPM_INFO_IMG]
+![NPM\_INFO][NPM_INFO_IMG]
 
 ## Command line parameters
 
@@ -68,12 +66,12 @@ const express = require('express');
 const app = express();
 
 app.use(edward({
-    root: '/',              // default
-    online: true,           // default
-    diff: true,             // default
-    zip: true,              // default
-    dropbox: false,         // optional
-    dropboxToken: 'token',  // optional
+    root: '/', // default
+    online: true, // default
+    diff: true, // default
+    zip: true, // default
+    dropbox: false, // optional
+    dropboxToken: 'token', // optional
 }));
 
 app.listen(31_337);

bin/edward.js

@@ -41,12 +41,12 @@ function main(name) {
 
     const {env} = process;
 
-    const port = env.PORT || /* c9           */
-                    env.VCAP_APP_PORT || /* cloudfoundry */
-                    1337;
+    const port = env.PORT /* c9           */
+                    || env.VCAP_APP_PORT /* cloudfoundry */
+                    || 1337;
 
-    const ip = env.IP || /* c9           */
-                '0.0.0.0';
+    const ip = env.IP /* c9           */
+                || '0.0.0.0';
 
     app .use(express.static(DIR))
         .use(edward({
@@ -56,7 +56,7 @@ function main(name) {
 
     server.listen(port, ip);
 
-    const socket = io.listen(server);
+    const socket = io(server);
     const edSocket = edward.listen(socket);
 
     edSocket.on('connection', () => {

bower.json

@@ -1,22 +1,22 @@
 {
-  "name": "edward",
-  "homepage": "https://github.com/cloudcmd/edward",
-  "authors": [
-    "coderaiser <mnemonic.enemy@gmail.com>"
-  ],
-  "description": "web editor",
-  "main": "bin/edward.js",
-  "keywords": [
-    "file",
-    "edit"
-  ],
-  "license": "MIT",
-  "private": true,
-  "ignore": [
-    "node_modules",
-    "modules"
-  ],
-  "dependencies": {
-    "ace-builds": "^1.5.0"
-  }
+    "name": "edward",
+    "homepage": "https://github.com/cloudcmd/edward",
+    "authors": [
+        "coderaiser <mnemonic.enemy@gmail.com>"
+    ],
+    "description": "web editor",
+    "main": "bin/edward.js",
+    "keywords": [
+        "file",
+        "edit"
+    ],
+    "license": "MIT",
+    "private": true,
+    "ignore": [
+        "node_modules",
+        "modules"
+    ],
+    "dependencies": {
+        "ace-builds": "^1.5.0"
+    }
 }

client/_clipboard.js

@@ -34,7 +34,9 @@ module.exports = function(cmd) {
         .then(insert)
         .catch(() => {
             showMessageOnce('Could not paste from clipboard. Inner buffer used.');
+            
             const value = _story.getData(NAME);
+            
             insert(value);
         });
 };

client/_on-save.js

@@ -19,7 +19,7 @@ module.exports = async function(error, text) {
         if (error.message)
             msg = error.message + '\n' + msg;
         else
-            msg = 'Can\'t save.' + msg;
+            msg = `Can't save.` + msg;
 
         const [cancel] = await tryToCatch(confirm, _title, msg);
 

client/edward.js

@@ -1,8 +1,9 @@
+'use strict';
+
+const isString = (a) => typeof a === 'string';
 /* global ace */
 /* global join */
 
-'use strict';
-
 require('../css/edward.css');
 
 const {createPatch} = require('daffy');
@@ -48,7 +49,7 @@ function Edward(el, options, callback) {
     if (!callback)
         callback = options;
 
-    if (typeof el === 'string')
+    if (isString(el))
         el = document.querySelector(el);
 
     this._maxSize = options._maxSize || 512_000;
@@ -347,7 +348,7 @@ Edward.prototype._setUseOfWorker = function(mode) {
     const session = this._getSession();
     const isStr = typeof mode === 'string';
     const regStr = 'coffee|css|html|json|lua|php|xquery';
-    const regExp = new RegExp(regStr);
+    const regExp = RegExp(regStr);
 
     let isMatch;
 
@@ -436,6 +437,7 @@ Edward.prototype._getSession = function() {
 Edward.prototype.sha = function() {
     const value = this.getValue();
     const shaObj = new jssha('SHA-1', 'TEXT');
+    
     shaObj.update(value);
 
     return shaObj.getHash('HEX');
@@ -557,12 +559,8 @@ Edward.prototype._loadFiles = function(callback) {
             };
 
             const scripts = Object.keys(obj)
-                .filter((name) => {
-                    return !window[name];
-                })
-                .map((name) => {
-                    return PREFIX + obj[name];
-                });
+                .filter((name) => !window[name])
+                .map((name) => PREFIX + obj[name]);
 
             if (scripts.lengths)
                 return callback();
@@ -582,11 +580,7 @@ Edward.prototype._loadFiles = function(callback) {
                 'language_tools',
                 'searchbox',
                 'modelist',
-            ].map((name) => {
-                return 'ext-' + name;
-            }).map((name) => {
-                return ace + name + '.js';
-            }));
+            ].map((name) => 'ext-' + name).map((name) => ace + name + '.js'));
 
             await load.js(url);
             callback();

client/loadremote.js

@@ -61,9 +61,7 @@ module.exports = async (name, options = {}) => {
         local = [module.local];
     }
 
-    local = local.map((url) => {
-        return prefix + url;
-    });
+    local = local.map((url) => prefix + url);
 
     const remote = remoteTmpls.map((tmpl) => {
         return tmpl.replace(/{{\sversion\s}}/g, version);