feature(fileop) class-properties, private methods

Author: coderaiser

.babelrc

@@ -1,4 +1,8 @@
 {
+  "plugins": [
+      "@babel/plugin-proposal-private-methods",
+      "@babel/plugin-proposal-class-properties"
+  ],
   "env": {
     "test": {
       "plugins": [

client/fileop.js

@@ -38,8 +38,8 @@ class Fileop extends Emitify {
             path: socketPath,
         });
 
-        this._setListeners(socket);
-        this.operate = promisify(this._operate);
+        this.#setListeners(socket);
+        this.operate = promisify(this.#operate);
         this.socket = socket;
     }
 
@@ -67,7 +67,7 @@ class Fileop extends Emitify {
         return this.operate('remove', from, files);
     }
 
-    _operate(name, from, to, files, fn = files) {
+    #operate(name, from, to, files, fn = files) {
         const {socket} = this;
 
         socket.emit('operation', name, from, to, files);
@@ -76,7 +76,7 @@ class Fileop extends Emitify {
         });
     }
 
-    _setListeners(socket) {
+    #setListeners(socket) {
         this.on('auth', (username, password) => {
             socket.emit('auth', username, password);
         });

client/operator.js

@@ -13,40 +13,35 @@ class FileOperator extends Emitify {
         this.socket = socket;
         this.id = id;
 
-        this._onError = this._onError.bind(this);
-        this._onFile = this._onFile.bind(this);
-        this._onProgress = this._onProgress.bind(this);
-        this._onEnd = this._onEnd.bind(this);
-        
-        socket.on(`${id}#error`, this._onError);
-        socket.on(`${id}#file`, this._onFile);
-        socket.on(`${id}#progress`, this._onProgress);
-        socket.on(`${id}#end`, this._onEnd);
+        socket.on(`${id}#error`, this.#onError);
+        socket.on(`${id}#file`, this.#onFile);
+        socket.on(`${id}#progress`, this.#onProgress);
+        socket.on(`${id}#end`, this.#onEnd);
 
         setTimeout(() => {
             socket.emit(`${id}#start`);
         }, 0);
     }
 
-    _onError(error) {
+    #onError = (error) => {
         this.emit('error', error);
     }
 
-    _onFile(name) {
+    #onFile = (name) => {
         this.emit('file', name);
     }
 
-    _onProgress(percent) {
+    #onProgress = (percent) => {
         this.emit('progress', percent);
     }
 
-    _onEnd() {
+    #onEnd = () => {
         const {id, socket} = this;
 
-        socket.off(`${id}#error`, this._onError);
-        socket.off(`${id}#file`, this._onFile);
-        socket.off(`${id}#progress`, this._onProgress);
-        socket.off(`${id}#end`, this._onEnd);
+        socket.off(`${id}#error`, this.#onError);
+        socket.off(`${id}#file`, this.#onFile);
+        socket.off(`${id}#progress`, this.#onProgress);
+        socket.off(`${id}#end`, this.#onEnd);
 
         this.emit('end');
     }

package.json

@@ -59,6 +59,8 @@
   "devDependencies": {
     "@babel/cli": "^7.0.0",
     "@babel/core": "^7.0.0",
+    "@babel/plugin-proposal-class-properties": "^7.3.0",
+    "@babel/plugin-proposal-private-methods": "^7.3.0",
     "@babel/preset-env": "^7.0.0",
     "@babel/register": "^7.0.0",
     "babel-eslint": "^10.0.0",

webpack.config.js

@@ -12,13 +12,11 @@ const devtool = isDev ? 'eval' : 'source-map';
 const notEmpty = (a) => a;
 const clean = (array) => array.filter(notEmpty);
 
-const rules = clean([
-    !isDev && {
-        test: /\.js$/,
-        exclude: /node_modules/,
-        loader: 'babel-loader',
-    }
-]);
+const rules = [{
+    test: /\.js$/,
+    exclude: /node_modules/,
+    loader: 'babel-loader',
+}];
 
 module.exports = {
     devtool,