fix(socket) prevent memory leak

Author: coderaiser

lib/socket.js

@@ -2,9 +2,8 @@
     'use strict';
 
     var path            = require('path'),
-        findit          = require('findit'),
 
-        assert          = require('assert'),
+        findit          = require('findit'),
         io              = require('socket.io'),
 
         Socket,
@@ -35,7 +34,8 @@
 
     function onConnection(socket, onMsg, callback) {
         var msg, onDisconnect, onMessage,
-            onFind  = function(conNum, data) {
+            indexEmpty  = Clients.indexOf(null),
+            onFind      = function(conNum, data) {
                 var dir, name,
                     d   = data;
 
@@ -55,10 +55,10 @@
             onMsg       = null;
         }
 
-        assert(socket, 'socket could not be empty!');
-        assert(callback, 'callback could not be empty!');
-        
-        ++ConNum;
+         if (indexEmpty >= 0)
+            ConNum = indexEmpty;
+        else
+            ConNum = Clients.length;
 
         if (!Clients[ConNum]) {
             msg = log(ConNum, 'find connected');
@@ -73,7 +73,12 @@
                 onFind(conNum, command);
             }.bind(null, ConNum),
             onDisconnect                = function(conNum) {
-                Clients[conNum]         = null;
+                 if (Clients.length !== conNum + 1) {
+                    Clients[conNum] = null;
+                } else {
+                    Clients.pop();
+                    --ConNum;
+                }
 
                 log(conNum, 'find disconnected');