Skip to content

Commit 48c6a39

Browse files
committed
fix: add deploymentConfig dependency within DepeloymentGroup and update readme
1 parent 522dcd3 commit 48c6a39

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

packages/cdk-blue-green-container-deployment/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,9 @@ export class BlueGreenContainerDeploymentStack extends Stack {
152152
prodTrafficListener: prodListener,
153153
testTrafficListener: testListener,
154154
terminationWaitTimeInMinutes: 100,
155-
deploymentConfig,
155+
deploymentConfig, // If you want to use default DeploymentConfig name, use static method which like "EcsDeploymentConfig.CANARY_10PERCENT_15MINUTES".
156156
});
157157

158-
deploymentGroup.node.addDependency(deploymentConfig);
159-
160158
// @see https://github.com/cloudcomponents/cdk-constructs/tree/master/examples/blue-green-container-deployment-example/blue-green-repository
161159
const repository = new Repository(this, 'CodeRepository', {
162160
repositoryName: 'blue-green-repository',

packages/cdk-blue-green-container-deployment/src/ecs-deployment-group.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,10 @@ export class EcsDeploymentGroup extends Resource implements IEcsDeploymentGroup
124124

125125
this.deploymentConfig = deploymentConfig || EcsDeploymentConfig.ALL_AT_ONCE;
126126

127+
if (Construct.isConstruct(props.deploymentConfig)) {
128+
this.node.addDependency(props.deploymentConfig);
129+
}
130+
127131
const ecsDeploymentGroup = new CustomResource(this, 'CustomResource', {
128132
serviceToken,
129133
resourceType: 'Custom::EcsDeploymentGroup',

0 commit comments

Comments
 (0)