Merge pull request #116 from kimisme9386/master

docs: update readme

Author: hupe1980

packages/cdk-blue-green-container-deployment/README.md

@@ -46,6 +46,7 @@ import { ImageRepository } from '@cloudcomponents/cdk-container-registry';
 import {
   EcsService,
   DummyTaskDefinition,
+  EcsDeploymentConfig,
   EcsDeploymentGroup,
   PushImageProject,
 } from '@cloudcomponents/cdk-blue-green-container-deployment';
@@ -125,7 +126,7 @@ export class BlueGreenContainerDeploymentStack extends Stack {
     ecsService.connections.allowFrom(loadBalancer, Port.tcp(80));
     ecsService.connections.allowFrom(loadBalancer, Port.tcp(8080));
 
-    const ecsDeploymentConfiguration = new EcsDeploymentConfiguration(
+    const deploymentConfig = new EcsDeploymentConfig(
       this,
       'DeploymentConfig',
       {
@@ -151,11 +152,9 @@ export class BlueGreenContainerDeploymentStack extends Stack {
       prodTrafficListener: prodListener,
       testTrafficListener: testListener,
       terminationWaitTimeInMinutes: 100,
-      deploymentConfig: ecsDeploymentConfiguration,
+      deploymentConfig, // If you want to use default DeploymentConfig name, use static method as "EcsDeploymentConfig.CANARY_10PERCENT_15MINUTES".
     });
 
-    deploymentGroup.node.addDependency(ecsDeploymentConfiguration);
-
     // @see https://github.com/cloudcomponents/cdk-constructs/tree/master/examples/blue-green-container-deployment-example/blue-green-repository
     const repository = new Repository(this, 'CodeRepository', {
       repositoryName: 'blue-green-repository',

packages/cdk-blue-green-container-deployment/src/ecs-deployment-group.ts

@@ -124,6 +124,10 @@ export class EcsDeploymentGroup extends Resource implements IEcsDeploymentGroup
 
     this.deploymentConfig = deploymentConfig || EcsDeploymentConfig.ALL_AT_ONCE;
 
+    if (Construct.isConstruct(props.deploymentConfig)) {
+      this.node.addDependency(props.deploymentConfig);
+    }
+
     const ecsDeploymentGroup = new CustomResource(this, 'CustomResource', {
       serviceToken,
       resourceType: 'Custom::EcsDeploymentGroup',