Skip to content

Commit fdd6395

Browse files
hupe1980hupe1980
authored
Merge pull request #122 from mbp/use-correct-artifacts-override-for-pr-check
Remove artifactsOverrides from Pull Request Check Rule, serves no purpose.
2 parents 3cae091 + 5941717 commit fdd6395

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

‎packages/cdk-pull-request-check/src/__tests__/__snapshots__/pull-request-check.test.ts.snap

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ Object {
398398
"detail-revisionId": "$.detail.revisionId",
399399
"detail-sourceCommit": "$.detail.sourceCommit",
400400
},
401-
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"artifactsOverride\\":{\\"type\\":\\"NO_ARTIFACTS\\"},\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
401+
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
402402
},
403403
"RoleArn": Object {
404404
"Fn::GetAtt": Array [
@@ -826,7 +826,7 @@ Object {
826826
"detail-revisionId": "$.detail.revisionId",
827827
"detail-sourceCommit": "$.detail.sourceCommit",
828828
},
829-
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"artifactsOverride\\":{\\"type\\":\\"NO_ARTIFACTS\\"},\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
829+
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
830830
},
831831
"RoleArn": Object {
832832
"Fn::GetAtt": Array [
@@ -1254,7 +1254,7 @@ Object {
12541254
"detail-revisionId": "$.detail.revisionId",
12551255
"detail-sourceCommit": "$.detail.sourceCommit",
12561256
},
1257-
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"artifactsOverride\\":{\\"type\\":\\"NO_ARTIFACTS\\"},\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
1257+
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
12581258
},
12591259
"RoleArn": Object {
12601260
"Fn::GetAtt": Array [
@@ -1777,7 +1777,7 @@ Object {
17771777
"detail-revisionId": "$.detail.revisionId",
17781778
"detail-sourceCommit": "$.detail.sourceCommit",
17791779
},
1780-
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"artifactsOverride\\":{\\"type\\":\\"NO_ARTIFACTS\\"},\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
1780+
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
17811781
},
17821782
"RoleArn": Object {
17831783
"Fn::GetAtt": Array [
@@ -2234,7 +2234,7 @@ Object {
22342234
"detail-revisionId": "$.detail.revisionId",
22352235
"detail-sourceCommit": "$.detail.sourceCommit",
22362236
},
2237-
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"artifactsOverride\\":{\\"type\\":\\"NO_ARTIFACTS\\"},\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
2237+
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
22382238
},
22392239
"RoleArn": Object {
22402240
"Fn::GetAtt": Array [
@@ -2993,7 +2993,7 @@ Object {
29932993
"detail-revisionId": "$.detail.revisionId",
29942994
"detail-sourceCommit": "$.detail.sourceCommit",
29952995
},
2996-
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"artifactsOverride\\":{\\"type\\":\\"NO_ARTIFACTS\\"},\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
2996+
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
29972997
},
29982998
"RoleArn": Object {
29992999
"Fn::GetAtt": Array [
@@ -3048,7 +3048,7 @@ Object {
30483048
"detail-revisionId": "$.detail.revisionId",
30493049
"detail-sourceCommit": "$.detail.sourceCommit",
30503050
},
3051-
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"artifactsOverride\\":{\\"type\\":\\"NO_ARTIFACTS\\"},\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
3051+
"InputTemplate": "{\\"sourceVersion\\":<detail-sourceCommit>,\\"environmentVariablesOverride\\":[{\\"name\\":\\"pullRequestId\\",\\"value\\":<detail-pullRequestId>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"repositoryName\\",\\"value\\":<detail-repositoryNames-0->,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"sourceCommit\\",\\"value\\":<detail-sourceCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"destinationCommit\\",\\"value\\":<detail-destinationCommit>,\\"type\\":\\"PLAINTEXT\\"},{\\"name\\":\\"revisionId\\",\\"value\\":<detail-revisionId>,\\"type\\":\\"PLAINTEXT\\"}]}",
30523052
},
30533053
"RoleArn": Object {
30543054
"Fn::GetAtt": Array [

‎packages/cdk-pull-request-check/src/pull-request-check.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ export class PullRequestCheck extends Construct {
203203
new CodeBuildProject(this.pullRequestProject, {
204204
event: RuleTargetInput.fromObject({
205205
sourceVersion: EventField.fromPath('$.detail.sourceCommit'),
206-
artifactsOverride: { type: 'NO_ARTIFACTS' },
207206
environmentVariablesOverride: [
208207
{
209208
name: 'pullRequestId',

0 commit comments

Comments
 (0)