feat: update plan commands

Author: anket-cd

internal/terraform/plan.go

@@ -1,107 +1,118 @@
 package terraform
 
 import (
+	"bytes"
 	"context"
-	"fmt"
 	"os"
 
 	"github.com/clouddrove/smurf/internal/ai"
 	"github.com/hashicorp/terraform-exec/tfexec"
 )
 
-func Plan(
-	vars []string,
-	varFiles []string,
-	dir string,
-	destroy bool,
-	targets []string,
-	refresh bool,
-	state string,
-	out string,
-	jsonOutput bool,
-	pushToCloud bool,
-	useAI bool,
-) error {
-
+// Plan runs 'terraform plan' and outputs the plan to the console.
+// It allows setting variables either via command-line arguments or variable files.
+// The function provides user feedback through spinners and colored messages,
+// and handles any errors that occur during the planning process.
+func Plan(vars []string, varFiles []string,
+	dir string, destroy bool,
+	targets []string, refresh bool,
+	state string, out string,
+	useAI bool) error {
 	tf, err := GetTerraform(dir)
 	if err != nil {
-		Error("Failed to initialize Terraform: %v", err)
+		Error("Failed to initialize Terraform client: %v", err)
 		ai.AIExplainError(useAI, err.Error())
 		return err
 	}
 
-	tf.SetStdout(os.Stdout)
+	var outputBuffer bytes.Buffer
+	customWriter := &CustomColorWriter{
+		Buffer: &outputBuffer,
+		Writer: os.Stdout,
+	}
+
+	tf.SetStdout(customWriter)
 	tf.SetStderr(os.Stderr)
 
+	// Start planning process
+	Info("Starting infrastructure planning in directory: %s", dir)
+
 	planOptions := []tfexec.PlanOption{}
 
+	// Handle state file
 	if state != "" {
+		Info("Using custom state file: %s", state)
 		planOptions = append(planOptions, tfexec.State(state))
 	}
 
+	// Handle output plan file
 	if out != "" {
+		Info("Saving execution plan to: %s", out)
 		planOptions = append(planOptions, tfexec.Out(out))
 	}
 
-	for _, v := range vars {
-		planOptions = append(planOptions, tfexec.Var(v))
+	// Apply variables
+	if len(vars) > 0 {
+		for _, v := range vars {
+			Info("Applying variable: %s", v)
+			planOptions = append(planOptions, tfexec.Var(v))
+		}
 	}
 
-	for _, vf := range varFiles {
-		planOptions = append(planOptions, tfexec.VarFile(vf))
+	// Apply variable files
+	if len(varFiles) > 0 {
+		for _, vf := range varFiles {
+			Info("Loading variable file: %s", vf)
+			planOptions = append(planOptions, tfexec.VarFile(vf))
+		}
 	}
 
-	for _, target := range targets {
-		planOptions = append(planOptions, tfexec.Target(target))
+	// Handle targets
+	if len(targets) > 0 {
+		Info("Targeting %d resource(s)...", len(targets))
+		for _, target := range targets {
+			Info("Using target: %s", target)
+			planOptions = append(planOptions, tfexec.Target(target))
+		}
 	}
 
+	// Destroy flag support
 	if destroy {
+		Warn("Planning for destruction of infrastructure resources...")
 		planOptions = append(planOptions, tfexec.Destroy(true))
 	}
 
+	// Refresh flag support
 	if !refresh {
+		Info("Skipping state refresh...")
 		planOptions = append(planOptions, tfexec.Refresh(false))
 	}
 
-	// Execute plan
+	// Execute Terraform plan and get the hasChanges boolean
 	hasChanges, err := tf.Plan(context.Background(), planOptions...)
+
 	if err != nil {
 		ai.AIExplainError(useAI, err.Error())
 		return err
 	}
 
+	// Check if there are any changes
 	if !hasChanges {
-		Success("✔ No changes. Infrastructure is up-to-date.")
-		return nil
-	}
-
-	Success("Plan completed successfully.")
+		Success("\nNo changes. Your infrastructure matches the configuration.")
 
-	// -----------------------------
-	// JSON Output Section
-	// -----------------------------
-	if jsonOutput {
-
-		if out == "" {
-			return fmt.Errorf("JSON output requires --out plan file")
-		}
-
-		Info("Generating JSON plan output...")
-
-		planJSON, err := tf.ShowPlanFileRaw(context.Background(), out)
-		if err != nil {
-			return err
-		}
-
-		jsonFile := "plan.json"
-
-		// FIXED HERE 👇
-		err = os.WriteFile(jsonFile, []byte(planJSON), 0644)
-		if err != nil {
-			return err
+		if out != "" {
+			Info("Note: Plan file was saved even though no changes detected: %s", out)
 		}
+		return nil
+	}
 
-		Success("JSON plan saved to %s", jsonFile)
+	// Changes detected
+	if out != "" {
+		Success("Terraform plan saved to: %s", out)
+		Info("To apply this plan, run: smurf stf apply %s", out)
+	} else {
+		Success("Terraform plan executed successfully. Review the changes above before applying.")
+		Warn("Note: No plan file was saved. To save and apply later, use: smurf stf plan --out=plan.tfplan")
 	}
 
 	return nil