Merge pull request #17 from clouddrove/0.15

add-mutipal-domain

Author: anmolnagpal

.github/workflows/terraform.yml

@@ -12,7 +12,7 @@ jobs:
         uses: actions/[email protected]
 
       - name: 'Terraform Format'
-        uses: 'clouddrove/github-actions@v6.0'
+        uses: 'clouddrove/github-actions@v7.0'
         with:
           actions_subcommand: 'fmt'
 
@@ -32,24 +32,24 @@ jobs:
           aws-region: us-east-2
 
       - name: 'Terraform init for generate certificate dns'
-        uses: 'clouddrove/github-actions@v6.0'
+        uses: 'clouddrove/github-actions@v7.0'
         with:
           actions_subcommand: 'init'
           tf_actions_working_dir: ./_example/generate-certificate-dns
 
       - name: 'Terraform validate for generate certificate dns'
-        uses: 'clouddrove/github-actions@v6.0'
+        uses: 'clouddrove/github-actions@v7.0'
         with:
           actions_subcommand: 'validate'
           tf_actions_working_dir: ./_example/generate-certificate-dns
 
       - name: 'Terraform plan for generate certificate dns'
-        uses: 'clouddrove/github-actions@v6.0'
+        uses: 'clouddrove/github-actions@v7.0'
         with:
           actions_subcommand: 'plan'
           tf_actions_working_dir: ./_example/generate-certificate-dns
   Email:
-    name: 'DNS'
+    name: 'Email'
     needs: fmt
     runs-on: ubuntu-latest
     steps:
@@ -65,19 +65,38 @@ jobs:
           aws-region: us-east-2
 
       - name: 'Terraform init for generate certificate email'
-        uses: 'clouddrove/github-actions@v6.0'
+        uses: 'clouddrove/github-actions@v7.0'
         with:
           actions_subcommand: 'init'
           tf_actions_working_dir: ./_example/generate-certificate-email
 
       - name: 'Terraform validate for generate certificate email'
-        uses: 'clouddrove/github-actions@v6.0'
+        uses: 'clouddrove/github-actions@v7.0'
         with:
           actions_subcommand: 'validate'
           tf_actions_working_dir: ./_example/generate-certificate-email
 
       - name: 'Terraform plan for generate certificate email'
-        uses: 'clouddrove/github-actions@v6.0'
+        uses: 'clouddrove/github-actions@v7.0'
         with:
           actions_subcommand: 'plan'
           tf_actions_working_dir: ./_example/generate-certificate-email
+
+  pre-commit:
+    name: 'Pre-Commit'
+    needs:
+      - fmt
+      - DNS
+      - Email
+    runs-on: ubuntu-latest
+    steps:
+      - name: 'Checkout'
+        uses: actions/[email protected]
+
+      - name: 'Install Tflint'
+        run: |
+          curl https://raw.githubusercontent.com/terraform-linters/tflint/master/install_linux.sh | bash
+
+      - name: 'Pre-Commit 🔎'
+        uses: pre-commit/[email protected]
+        continue-on-error: true

.pre-commit-config.yaml

@@ -5,9 +5,10 @@ repos:
     hooks:
       - id: terraform-fmt
       - id: shellcheck
+      - id: tflint
 
   - repo: git://github.com/pre-commit/pre-commit-hooks
-    rev: v3.4.0 # Use the ref you want to point at
+    rev: v4.0.1 # Use the ref you want to point at
     hooks:
       - id: end-of-file-fixer
       - id: trailing-whitespace

README.md

@@ -7,7 +7,7 @@
     Terraform Aws Acm
 </h1>
 
-<p align="center" style="font-size: 1.2rem;"> 
+<p align="center" style="font-size: 1.2rem;">
     This terraform module is used for requesting or importing SSL/TLS certificate with validation.
      </p>
 
@@ -38,7 +38,7 @@
 <hr>
 
 
-We eat, drink, sleep and most importantly love **DevOps**. We are working towards strategies for standardizing architecture while ensuring security for the infrastructure. We are strong believer of the philosophy <b>Bigger problems are always solved by breaking them into smaller manageable problems</b>. Resonating with microservices architecture, it is considered best-practice to run database, cluster, storage in smaller <b>connected yet manageable pieces</b> within the infrastructure. 
+We eat, drink, sleep and most importantly love **DevOps**. We are working towards strategies for standardizing architecture while ensuring security for the infrastructure. We are strong believer of the philosophy <b>Bigger problems are always solved by breaking them into smaller manageable problems</b>. Resonating with microservices architecture, it is considered best-practice to run database, cluster, storage in smaller <b>connected yet manageable pieces</b> within the infrastructure.
 
 This module is basically combination of [Terraform open source](https://www.terraform.io/) and includes automatation tests and examples. It also helps to create and improve your infrastructure with minimalistic code instead of maintaining the whole infrastructure code yourself.
 
@@ -49,7 +49,7 @@ We have [*fifty plus terraform modules*][terraform_modules]. A few of them are c
 
 ## Prerequisites
 
-This module has a few dependencies: 
+This module has a few dependencies:
 
 - [Terraform 0.13](https://learn.hashicorp.com/terraform/getting-started/install.html)
 - [Go](https://golang.org/doc/install)
@@ -154,7 +154,7 @@ module "acm" {
 
 
 ## Testing
-In this module testing is performed with [terratest](https://github.com/gruntwork-io/terratest) and it creates a small piece of infrastructure, matches the output like ARN, ID and Tags name etc and destroy infrastructure in your AWS account. This testing is written in GO, so you need a [GO environment](https://golang.org/doc/install) in your system. 
+In this module testing is performed with [terratest](https://github.com/gruntwork-io/terratest) and it creates a small piece of infrastructure, matches the output like ARN, ID and Tags name etc and destroy infrastructure in your AWS account. This testing is written in GO, so you need a [GO environment](https://golang.org/doc/install) in your system.
 
 You need to run the following command in the testing folder:
 ```hcl
@@ -163,7 +163,7 @@ You need to run the following command in the testing folder:
 
 
 
-## Feedback 
+## Feedback
 If you come accross a bug or have any feedback, please log it in our [issue tracker](https://github.com/clouddrove/terraform-aws-acm/issues), or feel free to drop us an email at [[email protected]](mailto:[email protected]).
 
 If you have found it worth your time, go ahead and give us a ★ on [our GitHub](https://github.com/clouddrove/terraform-aws-acm)!

README.yaml

@@ -16,7 +16,7 @@ github_repo: clouddrove/terraform-aws-acm
 # Badges to display
 badges:
   - name: "Terraform"
-    image: "https://img.shields.io/badge/Terraform-v0.14-green"
+    image: "https://img.shields.io/badge/Terraform-v0.15-green"
     url: "https://www.terraform.io"
   - name: "Licence"
     image: "https://img.shields.io/badge/License-MIT-blue.svg"
@@ -37,7 +37,7 @@ usage : |-
   ```hcl
   module "acm" {
     source                   = "clouddrove/acm/aws"
-    version                  = "0.14.0"
+    version                  = "0.15.0"
     name                     = "certificate"
     environment              = "test"
     label_order              = ["name","environment"]
@@ -52,7 +52,7 @@ usage : |-
   ```hcl
   module "acm" {
     source                = "clouddrove/acm/aws"
-    version               = "0.14.0"
+    version               = "0.15.0"
     name                  = "certificate"
     environment           = "test"
     label_order          = ["name","environment"]
@@ -67,7 +67,7 @@ usage : |-
   ```hcl
   module "acm" {
     source              = "clouddrove/acm/aws"
-    version             = "0.14.0"
+    version             = "0.15.0"
     name                = "certificate"
     environment         = "test"
     label_order         = ["name","environment"]

_example/generate-certificate-dns/example.tf

@@ -9,8 +9,9 @@ module "acm" {
   environment = "test"
   label_order = ["name", "environment"]
 
-  enable_aws_certificate = true
-  domain_name            = "clouddrove.com"
-  validation_method      = "DNS"
-  enable_dns_validation  = false
+  enable_aws_certificate    = true
+  domain_name               = "clouddrove.com"
+  subject_alternative_names = ["www.clouddrove.com"]
+  validation_method         = "DNS"
+  enable_dns_validation     = false
 }

_example/generate-certificate-email/example.tf

@@ -9,8 +9,9 @@ module "acm" {
   environment = "test"
   label_order = ["name", "environment"]
 
-  validate_certificate   = false
-  domain_name            = "clouddrove.com"
-  validation_method      = "EMAIL"
-  enable_aws_certificate = true
+  validate_certificate      = false
+  domain_name               = "clouddrove.com"
+  subject_alternative_names = ["www.clouddrove.com"]
+  validation_method         = "EMAIL"
+  enable_aws_certificate    = true
 }