cetificates issues handled for PVC | correct error propagation for failed requests and jobs

Author: Khauneesh-AI

.gitignore

@@ -84,3 +84,5 @@ sample_200x100.csv
 Raw_Web_Visit_sample.csv
 Raw_Web_Visit_Sample.csv
 Raw_Web_Visit_Sample.csv
+app/test_models.py
+credit_card_example.json

app/core/model_handlers.py

@@ -316,9 +316,18 @@ def _handle_openai_request(self, prompt: str):
                 pool=5.0
             )
 
+            # Configure httpx client with certificate verification for private cloud
+            if os.path.exists("/etc/ssl/certs/ca-certificates.crt"):
+                http_client = httpx.Client(
+                    verify="/etc/ssl/certs/ca-certificates.crt",
+                    timeout=timeout_config
+                )
+            else:
+                http_client = httpx.Client(timeout=timeout_config)
+            
             client = OpenAI(
                 api_key=os.getenv('OPENAI_API_KEY'),
-                timeout=timeout_config
+                http_client=http_client
             )
             completion = client.chat.completions.create(
                 model=self.model_id,
@@ -380,10 +389,19 @@ def _handle_caii_request(self, prompt: str):
                 pool=5.0
             )
 
+            # Configure httpx client with certificate verification for private cloud
+            if os.path.exists("/etc/ssl/certs/ca-certificates.crt"):
+                http_client = httpx.Client(
+                    verify="/etc/ssl/certs/ca-certificates.crt",
+                    timeout=timeout_config
+                )
+            else:
+                http_client = httpx.Client(timeout=timeout_config)
+            
             client_ca = OpenAI(
                 base_url=caii_endpoint,
                 api_key=API_KEY,
-                timeout=timeout_config  # Use the comprehensive timeout configuration
+                http_client=http_client
             )
 
             completion = client_ca.chat.completions.create(

app/services/synthesis_service.py

@@ -1007,19 +1007,24 @@ async def generate_freeform(self, request: SynthesisRequest, job_name=None, is_d
                     json.dump(final_output, indent=2, fp=f)
                 self.logger.info(f"Saved {len(final_output)} results to {file_path}")
 
-            # Check if we have any critical model errors across all topics
-            has_critical_model_error = any(
-                topic_errors and any("ModelHandlerError" in error for error in topic_errors)
-                for _, _, topic_errors, _ in completed_topics
-            )
+            # Find the first critical model error message
+            first_critical_error = None
+            for _, _, topic_errors, _ in completed_topics:
+                if topic_errors:
+                    for error in topic_errors:
+                        if "ModelHandlerError" in error:
+                            first_critical_error = error
+                            break
+                    if first_critical_error:
+                        break
 
             # After saving (or if no data), check for critical errors
-            if has_critical_model_error:
+            if first_critical_error:
                 if final_output:
                     self.logger.info(f"Saved {len(final_output)} results before failing due to model errors")
                 else:
                     self.logger.info("No results to save before failing due to model errors")
-                raise APIError("Critical model errors encountered during generation")
+                raise APIError(first_critical_error)
 
             # Handle custom prompt, examples and schema
             custom_prompt_str = PromptHandler.get_default_custom_prompt(request.use_case, request.custom_prompt)