Merge pull request #58 from danbev/use-const

fabiojose · web-flow · commit e7343b799340 · 2020-04-20T09:57:56.000-03:00
Use const instead of var where applicable
diff --git a/lib/bindings/http/commons.js b/lib/bindings/http/commons.js
@@ -14,7 +14,7 @@ function sanityContentType(contentType) {
 
 function sanityAndClone(headers) {
 
-  var sanityHeaders = {};
+  const sanityHeaders = {};
 
   Array.from(Object.keys(headers))
     .filter((header) => Object.hasOwnProperty.call(headers, header))
diff --git a/lib/bindings/http/emitter_binary.js b/lib/bindings/http/emitter_binary.js
@@ -1,5 +1,5 @@
-var axios = require("axios");
-var empty = require("is-empty");
+const axios = require("axios");
+const empty = require("is-empty");
 
 const Constants = require("./constants.js");
 const defaults = {};
diff --git a/lib/bindings/http/emitter_binary_0_1.js b/lib/bindings/http/emitter_binary_0_1.js
@@ -1,4 +1,4 @@
-var axios = require("axios");
+const axios = require("axios");
 
 const Constants = require("./constants.js");
 
@@ -59,10 +59,10 @@ function HTTPBinary(configuration){
 HTTPBinary.prototype.emit = function(cloudevent){
 
   // Create new request object
-  var _config = JSON.parse(JSON.stringify(this.config));
+  const _config = JSON.parse(JSON.stringify(this.config));
 
   // Always set stuff in _config
-  var _headers = _config["headers"];
+  const _headers = _config["headers"];
 
   Object.keys(headerByGetter)
     .filter((getter) => cloudevent[getter]())
@@ -78,7 +78,7 @@ HTTPBinary.prototype.emit = function(cloudevent){
   _config["data"] = cloudevent.format().data;
 
   // EXTENSION CONTEXT ATTRIBUTES
-  var exts = cloudevent.getExtensions();
+  const exts = cloudevent.getExtensions();
   Object.keys(exts)
     .filter((ext) => Object.hasOwnProperty.call(exts, ext))
     .forEach((ext) => {
diff --git a/lib/bindings/http/emitter_structured.js b/lib/bindings/http/emitter_structured.js
@@ -1,4 +1,4 @@
-var axios = require("axios");
+const axios = require("axios");
 
 const Constants = require("./constants.js");
 const defaults = {};
diff --git a/lib/bindings/http/emitter_structured_0_1.js b/lib/bindings/http/emitter_structured_0_1.js
@@ -1,4 +1,4 @@
-var axios = require("axios");
+const axios = require("axios");
 
 const Constants = require("./constants.js");
 
@@ -17,7 +17,7 @@ function HTTPStructured(configuration){
 HTTPStructured.prototype.emit = function(cloudevent){
 
   // Create new request object
-  var _config = JSON.parse(JSON.stringify(this.config));
+  const _config = JSON.parse(JSON.stringify(this.config));
 
 
   // Set the cloudevent payload
diff --git a/lib/bindings/http/receiver_binary.js b/lib/bindings/http/receiver_binary.js
@@ -52,7 +52,7 @@ BinaryHTTPReceiver.prototype.check = function(payload, headers) {
   }
 
   // Clone and low case all headers names
-  var sanityHeaders = Commons.sanityAndClone(headers);
+  const sanityHeaders = Commons.sanityAndClone(headers);
 
   // Validation Level 1
   if(!this.allowedContentTypes
@@ -88,17 +88,17 @@ BinaryHTTPReceiver.prototype.parse = function(payload, headers) {
   this.check(payload, headers);
 
   // Clone and low case all headers names
-  var sanityHeaders = Commons.sanityAndClone(headers);
+  const sanityHeaders = Commons.sanityAndClone(headers);
 
-  var processedHeaders = [];
-  var cloudevent = new Cloudevent(this.Spec);
+  const processedHeaders = [];
+  const cloudevent = new Cloudevent(this.Spec);
 
   // dont worry, check() have seen what was required or not
   Array.from(Object.keys(this.setterByHeader))
     .filter((header) => sanityHeaders[header])
     .forEach((header) => {
-      var setterName = this.setterByHeader[header].name;
-      var parserFun   = this.setterByHeader[header].parser;
+      const setterName = this.setterByHeader[header].name;
+      const parserFun   = this.setterByHeader[header].parser;
 
       // invoke the setter function
       cloudevent[setterName](parserFun(sanityHeaders[header]));
diff --git a/lib/bindings/http/receiver_structured.js b/lib/bindings/http/receiver_structured.js
@@ -37,7 +37,7 @@ function StructuredHTTPReceiver(
 StructuredHTTPReceiver.prototype.check = function(payload, headers) {
   validateArgs(payload, headers);
 
-  var sanityHeaders = Commons.sanityAndClone(headers);
+  const sanityHeaders = Commons.sanityAndClone(headers);
 
   // Validation Level 1
   if(!this.allowedContentTypes
@@ -54,16 +54,16 @@ StructuredHTTPReceiver.prototype.check = function(payload, headers) {
 StructuredHTTPReceiver.prototype.parse = function(payload, headers) {
   this.check(payload, headers);
 
-  var sanityHeaders = Commons.sanityAndClone(headers);
+  const sanityHeaders = Commons.sanityAndClone(headers);
 
-  var contentType = sanityHeaders[Constants.HEADER_CONTENT_TYPE];
+  const contentType = sanityHeaders[Constants.HEADER_CONTENT_TYPE];
 
-  var parser = this.parserByMime[contentType];
-  var event  = parser.parse(payload);
+  const parser = this.parserByMime[contentType];
+  const event  = parser.parse(payload);
   this.spec.check(event);
 
-  var processedAttributes = [];
-  var cloudevent = new Cloudevent(this.Spec);
+  const processedAttributes = [];
+  const cloudevent = new Cloudevent(this.Spec);
 
   Array.from(Object.keys(this.setterByAttribute))
     .filter((attribute) => event[attribute])
diff --git a/lib/bindings/http/receiver_structured_0_2.js b/lib/bindings/http/receiver_structured_0_2.js
@@ -1,6 +1,6 @@
 const Constants = require("./constants.js");
 const Spec02    = require("../../specs/spec_0_2.js");
-var JSONParser  = require("../../formats/json/parser.js");
+const JSONParser  = require("../../formats/json/parser.js");
 
 const StructuredHTTPReceiver = require("./receiver_structured.js");
 
diff --git a/lib/bindings/http/receiver_structured_0_3.js b/lib/bindings/http/receiver_structured_0_3.js
@@ -1,6 +1,6 @@
 const Constants = require("./constants.js");
 const Spec      = require("../../specs/spec_0_3.js");
-var JSONParser  = require("../../formats/json/parser.js");
+const JSONParser  = require("../../formats/json/parser.js");
 
 const StructuredHTTPReceiver = require("./receiver_structured.js");
 
diff --git a/lib/bindings/http/receiver_structured_1.js b/lib/bindings/http/receiver_structured_1.js
@@ -1,6 +1,6 @@
 const Constants = require("./constants.js");
 const Spec      = require("../../specs/spec_1.js");
-var JSONParser  = require("../../formats/json/parser.js");
+const JSONParser  = require("../../formats/json/parser.js");
 
 const StructuredHTTPReceiver = require("./receiver_structured.js");
 
diff --git a/lib/bindings/http/unmarshaller.js b/lib/bindings/http/unmarshaller.js
@@ -1,5 +1,5 @@
-var StructuredReceiver = require("./receiver_structured_0_2.js");
-var BinaryReceiver     = require("./receiver_binary_0_2.js");
+const StructuredReceiver = require("./receiver_structured_0_2.js");
+const BinaryReceiver     = require("./receiver_binary_0_2.js");
 
 const Constants = require("./constants.js");
 const Commons   = require("./commons.js");
@@ -32,7 +32,7 @@ function validateArgs(payload, headers) {
 // Is it binary or structured?
 function resolveBindingName(payload, headers) {
 
-  var contentType =
+  const contentType =
     Commons.sanityContentType(headers[Constants.HEADER_CONTENT_TYPE]);
 
   if(contentType.startsWith(Constants.MIME_CE)){
@@ -52,7 +52,7 @@ function resolveBindingName(payload, headers) {
   }
 }
 
-var Unmarshaller = function(receiverByBinding) {
+const Unmarshaller = function(receiverByBinding) {
   this.receiverByBinding = receiverByBinding;
 };
 
@@ -61,17 +61,17 @@ Unmarshaller.prototype.unmarshall = function(payload, headers) {
     try {
       validateArgs(payload, headers);
 
-      var sanityHeaders = Commons.sanityAndClone(headers);
+      const sanityHeaders = Commons.sanityAndClone(headers);
 
       // Validation level 1
       if(!sanityHeaders[Constants.HEADER_CONTENT_TYPE]){
         throw {message: "content-type header not found"};
       }
 
       // Resolve the binding
-      var bindingName = resolveBindingName(payload, sanityHeaders);
+      const bindingName = resolveBindingName(payload, sanityHeaders);
 
-      var cloudevent =
+      const cloudevent =
         this.receiverByBinding[bindingName].parse(payload, sanityHeaders);
 
       resolve(cloudevent);
diff --git a/lib/bindings/http/unmarshaller_0_2.js b/lib/bindings/http/unmarshaller_0_2.js
@@ -1,14 +1,14 @@
 const GenericUnmarshaller = require("./unmarshaller.js");
 
-var StructuredReceiver = require("./receiver_structured_0_2.js");
-var BinaryReceiver     = require("./receiver_binary_0_2.js");
+const StructuredReceiver = require("./receiver_structured_0_2.js");
+const BinaryReceiver     = require("./receiver_binary_0_2.js");
 
 const RECEIVER_BY_BINDING = {
   structured : new StructuredReceiver(),
   binary     : new BinaryReceiver(),
 };
 
-var Unmarshaller = function() {
+const Unmarshaller = function() {
   this.unmarshaller = new GenericUnmarshaller(RECEIVER_BY_BINDING);
 };
 
diff --git a/lib/bindings/http/unmarshaller_0_3.js b/lib/bindings/http/unmarshaller_0_3.js
@@ -1,14 +1,14 @@
 const GenericUnmarshaller = require("./unmarshaller.js");
 
-var StructuredReceiver = require("./receiver_structured_0_3.js");
-var BinaryReceiver     = require("./receiver_binary_0_3.js");
+const StructuredReceiver = require("./receiver_structured_0_3.js");
+const BinaryReceiver     = require("./receiver_binary_0_3.js");
 
 const RECEIVER_BY_BINDING = {
   structured : new StructuredReceiver(),
   binary     : new BinaryReceiver(),
 };
 
-var Unmarshaller = function() {
+const Unmarshaller = function() {
   this.unmarshaller = new GenericUnmarshaller(RECEIVER_BY_BINDING);
 };
 
diff --git a/lib/cloudevent.js b/lib/cloudevent.js
@@ -1,10 +1,10 @@
-var Spec01           = require("./specs/spec_0_1.js");
-var Spec02           = require("./specs/spec_0_2.js");
-var JSONFormatter01  = require("./formats/json/formatter.js");
-var HTTPStructured01 = require("./bindings/http/emitter_structured_0_1.js");
-var HTTPStructured02 = require("./bindings/http/emitter_structured_0_2.js");
-var HTTPBinary01     = require("./bindings/http/emitter_binary_0_1.js");
-var {HTTPBinary02}   = require("./bindings/http/emitter_binary_0_2.js");
+const Spec01           = require("./specs/spec_0_1.js");
+const Spec02           = require("./specs/spec_0_2.js");
+const JSONFormatter01  = require("./formats/json/formatter.js");
+const HTTPStructured01 = require("./bindings/http/emitter_structured_0_1.js");
+const HTTPStructured02 = require("./bindings/http/emitter_structured_0_2.js");
+const HTTPBinary01     = require("./bindings/http/emitter_binary_0_1.js");
+const {HTTPBinary02}   = require("./bindings/http/emitter_binary_0_2.js");
 
 /*
  * Class created using the Builder Design Pattern.
diff --git a/lib/formats/json/parser.js b/lib/formats/json/parser.js
@@ -22,7 +22,7 @@ const asJSON = (v) => (isString(v) ? JSON.parse(v) : v);
  */
 function validateAndParse(payload) {
 
-  var json =
+  const json =
     Array.of(payload)
       .filter((p) => isDefinedOrThrow(p, nullOrIndefinedPayload))
       .filter((p) => isStringOrObjectOrThrow(p, invalidPayloadTypeError))
@@ -51,7 +51,7 @@ JSONParser.prototype.parse = function(payload) {
   }
 
   //is that string? is that JSON?
-  var valid = validateAndParse(toparse);
+  const valid = validateAndParse(toparse);
 
   return valid;
 };
diff --git a/lib/specs/spec_0_1.js b/lib/specs/spec_0_1.js
@@ -1,4 +1,4 @@
-var uuid = require("uuid/v4");
+const uuid = require("uuid/v4");
 
 function Spec01(_caller){
   this.payload = {
diff --git a/lib/specs/spec_0_2.js b/lib/specs/spec_0_2.js
@@ -1,6 +1,6 @@
-var uuid  = require("uuid/v4");
-var empty = require("is-empty");
-var Ajv   = require("ajv");
+const uuid  = require("uuid/v4");
+const empty = require("is-empty");
+const Ajv   = require("ajv");
 
 // Reserved attributes names
 const reserved = {
@@ -37,7 +37,7 @@ Spec02.prototype.check = function(ce){
   if(!toCheck) {
     toCheck = this.payload;
   }
-  var valid = validate(toCheck);
+  const valid = validate(toCheck);
 
   if(!valid) {
     throw {message: "invalid payload", errors: validate.errors};
diff --git a/lib/specs/spec_0_3.js b/lib/specs/spec_0_3.js
@@ -82,7 +82,7 @@ function Spec03(_caller){
  * Check the spec constraints
  */
 Spec03.prototype.check = function(ce){
-  var toCheck = (!ce ? this.payload : ce);
+  const toCheck = (!ce ? this.payload : ce);
 
   if(!isValidAgainstSchema(toCheck)) {
     throw {message: "invalid payload", errors: isValidAgainstSchema.errors};
diff --git a/lib/specs/spec_1.js b/lib/specs/spec_1.js
@@ -110,7 +110,7 @@ function Spec1(_caller) {
  * Check the spec constraints
  */
 Spec1.prototype.check = function(ce){
-  var toCheck = (!ce ? this.payload : ce);
+  const toCheck = (!ce ? this.payload : ce);
 
   if(!isValidAgainstSchema(toCheck)) {
     throw {message: "invalid payload", errors: isValidAgainstSchema.errors};

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-var axios = require("axios");`
	`1`	`+const axios = require("axios");`
`2`	`2`
`3`	`3`	`const Constants = require("./constants.js");`
`4`	`4`	`const defaults = {};`