Skip to content

Commit 70e3b66

Browse files
committed
Fix TryFrom<Data> impl for Vec<u8>
Fixes #163 Signed-off-by: Jim Crossley <[email protected]>
1 parent 65a4782 commit 70e3b66

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/binding/warp/filter.rs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,11 @@ async fn create_event(headers: HeaderMap, body: bytes::Bytes) -> Result<Event, R
4545

4646
#[cfg(test)]
4747
mod tests {
48-
use warp_lib as warp;
49-
5048
use super::to_event;
51-
use warp::test;
52-
5349
use crate::test::fixtures;
50+
use std::convert::TryInto;
51+
use warp::test;
52+
use warp_lib as warp;
5453

5554
#[tokio::test]
5655
async fn test_request() {
@@ -114,6 +113,12 @@ mod tests {
114113
.await
115114
.unwrap();
116115

116+
let mut event = result.clone();
117+
let (_datacontenttype, _dataschema, data) = event.take_data();
118+
let actual_payload: Vec<u8> = data.unwrap().try_into().unwrap();
119+
let expected_payload: Vec<u8> = serde_json::to_vec(&fixtures::json_data()).unwrap();
120+
assert_eq!(expected_payload, actual_payload);
121+
117122
assert_eq!(expected, result);
118123
}
119124
}

src/event/data.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ impl TryFrom<Data> for Vec<u8> {
6060

6161
fn try_from(value: Data) -> Result<Self, Self::Error> {
6262
match value {
63-
Data::Binary(v) => Ok(serde_json::from_slice(&v)?),
63+
Data::Binary(v) => Ok(v),
6464
Data::Json(v) => Ok(serde_json::to_vec(&v)?),
6565
Data::String(s) => Ok(s.into_bytes()),
6666
}

0 commit comments

Comments
 (0)