Skip to content

Commit ce1635f

Browse files
committed
Remove PR reviewer notes and unused Env interface
Deleted the PR reviewer note and review instructions from the changeset file for clarity. Also removed the unused Env interface from the example server code to clean up environment bindings.
1 parent 86e4e27 commit ce1635f

File tree

2 files changed

+0
-42
lines changed

2 files changed

+0
-42
lines changed

.changeset/brave-workflows-dance.md

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -85,39 +85,3 @@ Workflows are automatically tracked in `cf_agents_workflows` SQLite table:
8585
- Params/output NOT stored by default (could be large)
8686
8787
See `docs/workflows.md` for full documentation.
88-
89-
## PR Reviewer Note
90-
91-
## How to Review This PR
92-
93-
### Recommended reading order:
94-
95-
1. **`docs/workflows.md`** - Start here for the complete picture. Covers:
96-
- Why integrate Workflows with Agents
97-
- Quick start guide
98-
- Full API reference
99-
- Common patterns (background processing, approval flows, retry logic)
100-
101-
2. **`packages/agents/src/workflow-types.ts`** - All type definitions:
102-
- `AgentWorkflowParams` - Combined user + internal params
103-
- `WorkflowCallback` types (progress, complete, error, event)
104-
- `WorkflowInfo` - Parsed workflow tracking record
105-
- `WorkflowQueryCriteria` - For querying workflows
106-
107-
3. **`packages/agents/src/workflow.ts`** - The `AgentWorkflow` base class:
108-
- Constructor hook that initializes `this.agent` before `run()` executes
109-
- Helper methods: `reportProgress`, `reportComplete`, `reportError`, `sendEvent`, `broadcastToClients`
110-
- `getUserParams()` to extract user params without internal fields
111-
112-
4. **`packages/agents/src/index.ts`** - Agent class additions (search for `cf_agents_workflows`):
113-
- SQLite table schema and initialization
114-
- `runWorkflow()` - Starts workflow and tracks it
115-
- `getWorkflow()` / `getWorkflows()` - Query tracked workflows
116-
- `sendWorkflowEvent()` - Send events to waiting workflows
117-
- `onWorkflowCallback()` and `onWorkflow*` lifecycle methods
118-
- HTTP endpoints at `/_workflow/callback` and `/_workflow/broadcast`
119-
120-
5. **Tests** (in order):
121-
- `packages/agents/src/tests/test-workflow.ts` - Example test workflows
122-
- `packages/agents/src/tests/workflow.test.ts` - Unit tests for tracking and callbacks
123-
- `packages/agents/src/tests/workflow-integration.test.ts` - Integration tests with introspection

examples/workflows/src/server.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,6 @@ import { Agent, AgentWorkflow, callable, routeAgentRequest } from "agents";
1212
import type { AgentWorkflowParams, DefaultProgress } from "agents";
1313
import type { WorkflowEvent, WorkflowStep } from "cloudflare:workers";
1414

15-
// Environment bindings
16-
interface Env {
17-
TaskAgent: DurableObjectNamespace;
18-
TASK_WORKFLOW: Workflow;
19-
}
20-
2115
// Workflow parameters
2216
type TaskParams = {
2317
taskId: string;

0 commit comments

Comments
 (0)