Only lint and format once pre-push

Author: andyjessop

.github/workflows/ci.yml

@@ -18,13 +18,11 @@ jobs:
       CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
       CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
     steps:
-      # Checkout the repository
       - name: Checkout code
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
-      # Set up Node.js with caching for npm dependencies
       - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
@@ -41,18 +39,20 @@ jobs:
           restore-keys: |
             nx-cache-${{ runner.os }}-
 
-      # Install dependencies
       - name: Install dependencies
         run: npm ci
 
-      # Set commit shas for Nx if needed
+      - name: Format and lint everything
+        run: |
+          npm run format
+          npm run lint
+
       - name: Set Nx SHAs
         uses: nrwl/nx-set-shas@v4
 
-      # Run Nx tasks including the staging deployment and extract the URL.
-      - name: Run Nx tasks including staging deployment
+      - name: Run Nx tasks
         id: checks
-        run: npx nx affected -t lint test:ci type-check build # deploy:staging
+        run: npx nx affected -t lint test:ci type-check build
 
       - name: Cache Nx folder
         uses: actions/cache@v3

.github/workflows/smoke.yml

@@ -35,6 +35,6 @@ jobs:
         uses: nrwl/nx-set-shas@v4
 
       # Run Nx tasks including the staging deployment and extract the URL.
-      - name: Run Nx tasks including staging deployment
+      - name: Run smoke tests
         id: checks
-        run: npx nx run-many -t lint test:smoke type-check build
+        run: npx nx run-many -t test:smoke

.husky/pre-push

@@ -37,8 +37,7 @@ if [ "$ORIGINAL_HASH" != "$NEW_HASH" ]; then
   exit 1
 fi
 
-# 6. Run Nx format across all projects.
-npx nx run-many -t format lint:fix
+# 6. Format and lint everything
 npm run format
 npm run lint:fix
 
@@ -52,4 +51,4 @@ if [ -n "$(git status --porcelain)" ]; then
 fi
 
 # 8. Continue with the remaining pre-push commands.
-npx nx affected --base=main --head=HEAD -t lint types test:ci type-check build
+npx nx affected --base=main --head=HEAD -t types test:ci type-check build

package.json

@@ -5,6 +5,7 @@
 		"create-demo": "npx tsx ./tools/create-demo/index.ts",
 		"prepare": "husky",
 		"format": "biome format --write",
+		"lint": "biome lint",
 		"lint:fix": "biome lint --fix"
 	},
 	"devDependencies": {