Skip to content

Commit 7cc17da

Browse files
committed
Inline changeset-{version,publish}.ts into workflow.
These scripts seem to have no purpose except to run shell commands. We can just run the shell commands directly from the shell. This removes a layer of indirection, making it easier to see what's going on.
1 parent 50b38fd commit 7cc17da

File tree

3 files changed

+6
-20
lines changed

3 files changed

+6
-20
lines changed

.github/changeset-publish.ts

Lines changed: 0 additions & 5 deletions
This file was deleted.

.github/changeset-version.ts

Lines changed: 0 additions & 13 deletions
This file was deleted.

.github/workflows/release.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,12 @@ jobs:
3939
- id: changesets
4040
uses: changesets/action@v1
4141
with:
42-
version: npx tsx .github/changeset-version.ts
43-
publish: npx tsx .github/changeset-publish.ts
42+
# The standard step is only to run `changeset version` but this does not update the
43+
# package-lock.json file. So we also run `npm install`, which does this update.
44+
# This is a workaround until this is handled automatically by `changeset version`.
45+
# See https://github.com/changesets/changesets/issues/421.
46+
version: npx changeset version && npm install
47+
publish: npx changeset publish
4448
env:
4549
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4650

0 commit comments

Comments
 (0)