should capnweb support commonjs ?

[romainPrignon]

hi 🙂

I just tried to install capnweb on a commonjs project and I got

node:internal/modules/esm/resolve:314
  return new ERR_PACKAGE_PATH_NOT_EXPORTED(
         ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in /home/exp-capnweb/node_modules/capnweb/package.json
    at exportsNotFound (node:internal/modules/esm/resolve:314:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:605:13)
    at resolveExports (node:internal/modules/cjs/loader:638:36)
    at Function._findPath (node:internal/modules/cjs/loader:743:31)
    at node:internal/modules/cjs/loader:1230:27
    at nextResolveSimple (/home/exp-capnweb/node_modules/.pnpm/tsx@4.20.6/node_modules/tsx/dist/register-D46fvsV_.cjs:4:1004)
    at /home/exp-capnweb/node_modules/.pnpm/tsx@4.20.6/node_modules/tsx/dist/register-D46fvsV_.cjs:3:2630
    at /home/exp-capnweb/node_modules/.pnpm/tsx@4.20.6/node_modules/tsx/dist/register-D46fvsV_.cjs:3:1542
    at resolveTsPaths (/home/exp-capnweb/node_modules/.pnpm/tsx@4.20.6/node_modules/tsx/dist/register-D46fvsV_.cjs:4:760)
    at /home/exp-capnweb/node_modules/.pnpm/tsx@4.20.6/node_modules/tsx/dist/register-D46fvsV_.cjs:4:1102 {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

Node.js v22.13.0

I solved it by adding in my package.json

"type": "module",

• should capnweb support commonjs as well as esm ?
• if no, should it be added to the readme somewhere ?

[burdiyan]

Not that anybody asked me, but I think in this day and age nothing should support CJS anymore. It's been a decade since ES6 🙃.

[mwstr]

https://antfu.me/posts/move-on-to-esm-only

[kentonv]

If someone feels strongly enough about this to come up with a PR -- and assuming that PR is not too invasive -- I'm willing to consider it.

But yeah kind of feel like everyone should be using ESM by now. :)

[kentonv]

Fixed by #107.