Skip to content

Commit 0612f54

Browse files
Cherryelithrar
authored andcommitted
[Docs Site] Remove unnecessary DOMContentLoaded listeners (#16834)
1 parent f0906c7 commit 0612f54

File tree

3 files changed

+15
-20
lines changed

3 files changed

+15
-20
lines changed

src/components/overrides/Head.astro

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -167,12 +167,10 @@ if (Astro.props.entry.data.external_link) {
167167
<script>
168168
import littlefoot from "littlefoot";
169169

170-
document.addEventListener("DOMContentLoaded", () => {
171-
littlefoot();
172-
document
173-
.querySelectorAll("span.littlefoot")
174-
.forEach((x) => x.classList.add("not-content"));
175-
});
170+
littlefoot();
171+
document
172+
.querySelectorAll("span.littlefoot")
173+
.forEach((x) => x.classList.add("not-content"));
176174
</script>
177175
<script>
178176
import mermaid from "mermaid";

src/pages/changelog/index.astro

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -89,17 +89,15 @@ const { products, productAreas, changelogs } = await getChangelogs();
8989
<script>
9090
import StickyHeader from "@codingheads/sticky-header";
9191

92-
document.addEventListener("DOMContentLoaded", () => {
93-
const navHeightRem = getComputedStyle(document.body).getPropertyValue(
94-
"--sl-nav-height",
95-
);
96-
const navHeightPx = Number(navHeightRem.split("rem")[0]) * 16 + 16;
92+
const navHeightRem = getComputedStyle(document.body).getPropertyValue(
93+
"--sl-nav-height",
94+
);
95+
const navHeightPx = Number(navHeightRem.split("rem")[0]) * 16 + 16;
9796

98-
const headers = document.querySelectorAll<HTMLElement>("[data-date] > h2");
99-
headers.forEach(
100-
(header) => new StickyHeader(header, { offset: 0 - navHeightPx }),
101-
);
102-
});
97+
const headers = document.querySelectorAll<HTMLElement>("[data-date] > h2");
98+
headers.forEach(
99+
(header) => new StickyHeader(header, { offset: 0 - navHeightPx }),
100+
);
103101

104102
const productFilter = document.querySelector<HTMLSelectElement>("#products");
105103
productFilter?.addEventListener("change", filterEntries);

src/pages/products.astro

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ const groups = productGroups(products);
158158
input.addEventListener("change", filterProducts);
159159
});
160160

161-
document.addEventListener("DOMContentLoaded", () => {
161+
function initProducts() {
162162
const params = new URLSearchParams(window.location.search);
163163

164164
const groups = params.get("product-group");
@@ -170,13 +170,12 @@ const groups = productGroups(products);
170170
if (!filters) return;
171171

172172
for (const filter of filters) {
173-
console.log(groups);
174-
console.log(filter.id);
175173
if (groups.includes(filter.id)) {
176174
filter.checked = true;
177175
}
178176
}
179177

180178
filterProducts();
181-
});
179+
}
180+
initProducts();
182181
</script>

0 commit comments

Comments
 (0)