Skip to content

Commit 1fd5d00

Browse files
authored
Remake client close PR (#16188)
1 parent 1d49f5b commit 1fd5d00

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

src/content/docs/hyperdrive/configuration/connect-to-postgres.mdx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,10 @@ export default {
120120
// A very simple test query
121121
const result = await sql`select * from pg_tables`
122122

123+
// Clean up the client, ensuring we don't kill the worker before that is
124+
// completed.
125+
ctx.waitUntil(sql.end());
126+
123127
// Return result rows as JSON
124128
return Response.json({ result: result });
125129
} catch (e) {
@@ -163,9 +167,7 @@ export interface Env {
163167
export default {
164168
async fetch(request, env, ctx): Promise<Response> {
165169

166-
// NOTE: if `prepare: false` is passed when connecting, performance will
167-
// be slower but still correctly supported.
168-
const sql = postgres(env.HYPERDRIVE.connectionString)
170+
const client = new Client({ connectionString: c.env.HYPERDRIVE.connectionString });
169171

170172
try {
171173
// Connect to your database
@@ -174,6 +176,10 @@ export default {
174176
// A very simple test query
175177
const result = await client.query({ text: 'SELECT * FROM pg_tables' });
176178

179+
// Clean up the client, ensuring we don't kill the worker before that is
180+
// completed.
181+
ctx.waitUntil(client.end());
182+
177183
// Return result rows as JSON
178184
return Response.json({ result: result });
179185
} catch (e) {

src/content/docs/hyperdrive/get-started.mdx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,10 @@ export default {
236236
// Test query
237237
const results = await sql`SELECT * FROM pg_tables`
238238

239+
// Clean up the client, ensuring we don't kill the worker before that is
240+
// completed.
241+
ctx.waitUntil(sql.end());
242+
239243
// Return result rows as JSON
240244
return Response.json(results);
241245
} catch (e) {

0 commit comments

Comments
 (0)