Skip to content

Commit 20e3c4a

Browse files
authored
[Workers] Add await writer.close() to get promise, otherwise it takes 4m30s to get the response from TCP sockets API (#17224)
### Summary Add await writer.close(), otherwise it takes 4m30s to get the response from TCP sockets ``` % date && curl https://abc.xyz.workers.dev && date Fri Jul 26 14:33:23 JST 2024 ... Fri Jul 26 14:37:53 JST 2024 ```
1 parent 88ff4d9 commit 20e3c4a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/content/docs/workers/runtime-apis/tcp-sockets.mdx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export default {
3636
const encoder = new TextEncoder();
3737
const encoded = encoder.encode(url.pathname + "\r\n");
3838
await writer.write(encoded);
39+
await writer.close();
3940

4041
return new Response(socket.readable, { headers: { "Content-Type": "text/plain" } });
4142
} catch (error) {
@@ -151,6 +152,7 @@ export default {
151152
const encoder = new TextEncoder();
152153
const encoded = encoder.encode("GET / HTTP/1.0\r\n\r\n");
153154
await writer.write(encoded);
155+
await writer.close();
154156

155157
return new Response(socket.readable, { headers: { "Content-Type": "text/plain" } });
156158
} catch (error) {

0 commit comments

Comments
 (0)