update secret and env vars page

Author: emily-shen

src/content/docs/containers/examples/env-vars-and-secrets.mdx

@@ -19,25 +19,21 @@ as environment variables.
 These examples show the various ways to pass in secrets and environment variables. In each, we will
 be passing in:
 
-- the variable `"ACCOUNT_NAME"` as a hard-coded environment variable
-- the secret `"CONTAINER_SECRET_KEY"` as a secret from Worker Secrets
-- the secret `"ACCOUNT_API_KEY"` as a secret from the Secret Store
+- the variable `"ENV_VAR"` as a hard-coded environment variable
+- the secret `"WORKER_SECRET"` as a secret from Worker Secrets
+- the secret `"SECRET_STORE_SECRET"` as a secret from the Secret Store
 
 In practice, you may just use one of the methods for storing secrets, but
 we will show both for completeness.
 
 ## Creating secrets
 
-First, let's create the `"CONTAINER_SECRET_KEY"` secret in Worker Secrets:
+First, let's create the `"WORKER_SECRET"` secret in Worker Secrets:
 
-<PackageManagers
-	type="exec"
-	pkg="wrangler"
-	args="secret put CONTAINER_SECRET_KEY"
-/>
+<PackageManagers type="exec" pkg="wrangler" args="secret put WORKER_SECRET" />
 
 Then, let's create a store called "demo" in the Secret Store, and add
-the `"ACCOUNT_API_KEY"` secret to it:
+the `"SECRET_STORE_SECRET"` secret to it:
 
 <PackageManagers
 	type="exec"
@@ -48,7 +44,7 @@ the `"ACCOUNT_API_KEY"` secret to it:
 <PackageManagers
 	type="exec"
 	pkg="wrangler"
-	args="secrets-store secret create demo --name ACCOUNT_API_KEY --scopes workers --remote"
+	args="secrets-store secret create demo --name SECRET_STORE_SECRET --scopes workers --remote"
 />
 
 For full details on how to create secrets, see the [Workers Secrets documentation](/workers/configuration/secrets/)
@@ -65,13 +61,13 @@ in Wrangler configuration.
 {
 	"name": "my-container-worker",
 	"vars": {
-		"ACCOUNT_NAME": "my-account"
+		"ENV_VAR": "my-env-var"
 	},
 	"secrets_store_secrets": [
 		{
 			"binding": "SECRET_STORE",
 			"store_id": "demo",
-			"secret_name": "ACCOUNT_API_KEY"
+			"secret_name": "SECRET_STORE_SECRET"
 		}
 	]
 	// rest of the configuration...
@@ -80,11 +76,11 @@ in Wrangler configuration.
 
 </WranglerConfig>
 
-Note that `"CONTAINER_SECRET_KEY"` does not need to be set, at it is automatically
+Note that `"WORKER_SECRET"` does not need to be specified in the Wrangler config file, as it is automatically
 added to `env`.
 
 Also note that we did not configure anything specific for environment variables
-or secrets in the container-related portion of wrangler configuration.
+or secrets in the _container-related_ portion of the Wrangler configuration file.
 
 ## Using `envVars` on the Container class
 
@@ -97,9 +93,9 @@ export class MyContainer extends Container {
 	defaultPort = 8080;
 	sleepAfter = "10s";
 	envVars = {
-		ACCOUNT_NAME: env.ACCOUNT_NAME,
-		ACCOUNT_API_KEY: env.SECRET_STORE.ACCOUNT_API_KEY,
-		CONTAINER_SECRET_KEY: env.CONTAINER_SECRET_KEY,
+		WORKER_SECRET: env.WORKER_SECRET,
+		ENV_VAR: env.ENV_VAR,
+		// we can't set the secret store binding as a default here, as getting the secret value is asynchronous
 	};
 }
 ```
@@ -112,7 +108,6 @@ set as environment variables when it launches.
 But what if you want to set environment variables on a per-instance basis?
 
 In this case, use the `startAndWaitForPorts()` method to pass in environment variables for each instance.
-We'll assume that we've set additional secrets in the Secret Store.
 
 ```js
 export class MyContainer extends Container {
@@ -124,26 +119,26 @@ export default {
 	async fetch(request, env) {
 		if (new URL(request.url).pathname === "/launch-instances") {
 			let instanceOne = env.MY_CONTAINER.getByName("foo");
-			let instanceTwo = env.MY_CONTAINER.getByName("foo");
+			let instanceTwo = env.MY_CONTAINER.getByName("bar");
 
 			// Each instance gets a different set of environment variables
 
 			await instanceOne.startAndWaitForPorts({
 				startOptions: {
 					envVars: {
-						ACCOUNT_NAME: env.ACCOUNT_NAME + "-1",
-						ACCOUNT_API_KEY: env.SECRET_STORE.ACCOUNT_API_KEY_ONE,
-						CONTAINER_SECRET_KEY: env.CONTAINER_SECRET_KEY_TWO,
+						ENV_VAR: env.ENV_VAR + "foo",
+						WORKER_SECRET: env.WORKER_SECRET,
+						SECRET_STORE_SECRET: await env.SECRET_STORE.get(),
 					},
 				},
 			});
 
 			await instanceTwo.startAndWaitForPorts({
 				startOptions: {
 					envVars: {
-						ACCOUNT_NAME: env.ACCOUNT_NAME + "-2",
-						ACCOUNT_API_KEY: env.SECRET_STORE.ACCOUNT_API_KEY_TWO,
-						CONTAINER_SECRET_KEY: env.CONTAINER_SECRET_KEY_TWO,
+						ENV_VAR: env.ENV_VAR + "foo",
+						WORKER_SECRET: env.ANOTHER_WORKER_SECRET,
+						SECRET_STORE_SECRET: await env.OTHER_SECRET_STORE.get(),
 					},
 				},
 			});