Skip to content

Commit 40a2725

Browse files
kodster28RebeccaTamachiro
authored andcommitted
Hyperlint config updates (#20671)
* [Hyperlint] Adjust settings * Custom review message * Remove comment from PR check * Revised * Update
1 parent 6fa795a commit 40a2725

File tree

2 files changed

+14
-37
lines changed

2 files changed

+14
-37
lines changed

.github/workflows/pr.yml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -18,27 +18,3 @@ jobs:
1818
- uses: ./.github/actions/assign-pr
1919
with:
2020
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
21-
22-
review_comment:
23-
name: Add review comment
24-
runs-on: ubuntu-latest
25-
steps:
26-
- id: check_if_contributor_is_external
27-
name: Check if contributor is external
28-
run: 'curl --write-out ''%{http_code}'' --silent --output /dev/null -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer ${{ env.GH_TOKEN }}" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/orgs/cloudflare/members/${{ github.event.pull_request.user.login }} | grep -q ''204'' && echo "is_external=false" >> $GITHUB_OUTPUT || echo "is_external=true" >> $GITHUB_OUTPUT'
29-
env:
30-
GH_TOKEN: ${{ secrets.HOLOPIN_LABELER }}
31-
- name: External comment
32-
run: gh pr comment "$NUMBER" --body "Howdy and thanks for contributing to our repo. We review new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment."
33-
if: steps.check_if_contributor_is_external.outputs.is_external == 'true'
34-
env:
35-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
36-
GH_REPO: ${{ github.repository }}
37-
NUMBER: ${{ github.event.pull_request.number }}
38-
- name: Internal comment
39-
run: gh pr comment "$NUMBER" --body "Howdy and thanks for contributing to our repo. We review internal PRs within **1 week**. If it's something urgent or has been sitting without a comment, start a thread in the *Developer Docs* space internally."
40-
if: steps.check_if_contributor_is_external.outputs.is_external == 'false'
41-
env:
42-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
43-
GH_REPO: ${{ github.repository }}
44-
NUMBER: ${{ github.event.pull_request.number }}

.hyperlint/config.yaml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
content_dir: /src/content
2-
authorized_users:
3-
- dcpena
4-
- kodster28
5-
- KianNH
6-
- marciocloudflare
7-
- pedrosousa
8-
- ranbel
9-
- RebeccaTamachiro
10-
style_guide:
2+
reviewer:
3+
custom_comment: |-
4+
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment.
5+
6+
We review internal PRs within **1 week**. If it's something urgent or has been sitting without a comment, start a thread in the *Developer Docs* space internally.
117
enabled: true
12-
openapi:
13-
enabled: true
14-
urls:
15-
- https://raw.githubusercontent.com/cloudflare/api-schemas/main/openapi.json
8+
external_link_validation:
9+
check_status_upon_review_failure: neutral
10+
summarize_pull_request:
11+
enabled: true
12+
vale_style_guide:
13+
check_status_upon_review_failure: neutral
14+
enabled: true
15+
limit_num_reviews: 2
16+
limit_num_comments: 7

0 commit comments

Comments
 (0)