Skip to content

Commit 4c2d044

Browse files
Apply suggestions from code review
Co-authored-by: James Opstad <[email protected]>
1 parent 6ff4810 commit 4c2d044

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

src/content/docs/workers/wrangler/commands.mdx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,6 @@ As of Wrangler v3.2.0, `wrangler dev` is supported by any Linux distributions pr
424424
- Skip Wrangler's build steps. Particularly useful when using custom builds. Refer to [Bundling](https://developers.cloudflare.com/workers/wrangler/bundling/) for more information.
425425
- `--env` <Type text="string" /> <MetaInfo text="optional" />
426426
- Perform on a specific environment.
427-
<Render file="vite-environments" />
428427
- `--compatibility-date` <Type text="string" /> <MetaInfo text="optional" />
429428
- A date in the form yyyy-mm-dd, which will be used to determine which version of the Workers runtime is used.
430429
- `--compatibility-flags`, `--compatibility-flag` <Type text="string[]" /> <MetaInfo text="optional" />

src/content/docs/workers/wrangler/configuration.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ Non-inheritable keys are configurable at the top-level, but cannot be inherited
200200
- `define` <Type text="Record<string, string>" /> <MetaInfo text="optional" />
201201

202202
- A map of values to substitute when deploying your Worker.
203-
- If you're using the [Cloudflare Vite plugin](/workers/vite-plugin/), this is replaced by Vite's [`define`](https://vite.dev/config/shared-options.html#define).
203+
- If you're using the [Cloudflare Vite plugin](/workers/vite-plugin/), `define` is replaced by Vite's [`define`](https://vite.dev/config/shared-options.html#define).
204204

205205
- `vars` <Type text="object" /> <MetaInfo text="optional" />
206206

@@ -1306,7 +1306,7 @@ This section describes a feature that can be implemented by frameworks and other
13061306

13071307
It is unlikely that an application developer will need to use this feature, but it is documented here to help you understand when Wrangler is using a generated configuration rather than the original, user's configuration.
13081308

1309-
For example, when you are using the [Cloudflare Vite plugin](/workers/vite-plugin/), it will generate a Wrangler configuration file when you run `vite build`, which is then used for preview and deployment.
1309+
For example, when using the [Cloudflare Vite plugin](/workers/vite-plugin/), an output Worker configuration file is generated as part of the build. This is then used for preview and deployment.
13101310

13111311
:::
13121312

src/content/partials/workers/vite-environments.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
---
44

55
:::note
6-
If you're using the [Cloudflare Vite plugin](/workers/vite-plugin/), you select a Wrangler environment at dev or build time via the `CLOUDFLARE_ENV` environment variable rather than the `--env` flag. Otherwise, environments are defined in your Wrangler config file as usual. For more detail on using Wrangler environments with the Cloudflare Vite plugin, refer to the [plugin documentation](/workers/vite-plugin/reference/cloudflare-environments/).
6+
If you're using the [Cloudflare Vite plugin](/workers/vite-plugin/), you select the environment at dev or build time via the `CLOUDFLARE_ENV` environment variable rather than the `--env` flag. Otherwise, environments are defined in your Worker config file as usual. For more detail on using environments with the Cloudflare Vite plugin, refer to the [plugin documentation](/workers/vite-plugin/reference/cloudflare-environments/).
77
:::

src/content/partials/workers/workers-assets-routing-summary.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
{}
33
---
44

5-
By default, Cloudflare first tries to match a request path against a static asset path, which is based on the file structure of the uploaded asset directory. This is either the directory specified by `assets.directory` in your Wrangler config, or the output directory of a build tool like Vite with the [Cloudflare Vite plugin](/workers/vite-plugin/). Failing that, we invoke a Worker if one is present. If there is no Worker, or the Worker then uses the asset binding, Cloudflare will fallback to the behaviour set by [`not_found_handling`](/workers/static-assets/routing/#not_found_handling).
5+
By default, Cloudflare first tries to match a request path against a static asset path, which is based on the file structure of the uploaded asset directory. This is either the directory specified by `assets.directory` in your Wrangler config or, in the case of the [Cloudflare Vite plugin](/workers/vite-plugin/), the output directory of the client build. Failing that, we invoke a Worker if one is present. If there is no Worker, or the Worker then uses the asset binding, Cloudflare will fallback to the behaviour set by [`not_found_handling`](/workers/static-assets/routing/#not_found_handling).
66

7-
Refer to the [routing documentation](/workers/static-assets/routing/#routing-configuration) for more information on how to routing works with Workers Assets, and how to customize this behavior.
7+
Refer to the [routing documentation](/workers/static-assets/routing/#routing-configuration) for more information about how routing works with static assets, and how to customize this behavior.

0 commit comments

Comments
 (0)