Skip to content

Commit 6683a39

Browse files
authored
remove sql.end/client.end() (#25426)
1 parent 8af20c6 commit 6683a39

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

src/content/docs/hyperdrive/tutorials/serverless-timeseries-api-with-timescale/index.mdx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ export default {
203203
headers: { "Content-Type": "application/json" },
204204
});
205205

206-
ctx.waitUntil(client.end());
207206
return resp;
208207

209208
// Create a route for querying within a time-frame
@@ -221,7 +220,6 @@ export default {
221220
headers: { "Content-Type": "application/json" },
222221
});
223222

224-
ctx.waitUntil(client.end());
225223
return resp;
226224
}
227225
},

src/content/docs/workers/databases/third-party-integrations/neon.mdx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ To connect to Neon using `@neondatabase/serverless`, follow these steps:
8181
const client = new Client(env.DATABASE_URL);
8282
await client.connect();
8383
const { rows } = await client.query("SELECT * FROM elements");
84-
ctx.waitUntil(client.end()); // this doesn’t hold up the response
8584

8685
return new Response(JSON.stringify(rows));
8786
},

src/content/partials/hyperdrive/use-node-postgres-to-make-query.mdx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@ Create a new `Client` instance and pass the Hyperdrive `connectionString`:
2929
import { Client } from "pg";
3030

3131
export default {
32-
async fetch(request: Request, env: Env, ctx: ExecutionContext): Promise<Response> {
32+
async fetch(
33+
request: Request,
34+
env: Env,
35+
ctx: ExecutionContext,
36+
): Promise<Response> {
3337
// Create a new client instance for each request.
3438
const client = new Client({
3539
connectionString: env.HYPERDRIVE.connectionString,
@@ -43,17 +47,14 @@ export default {
4347
// Perform a simple query
4448
const result = await client.query("SELECT * FROM pg_tables");
4549

46-
// Clean up the client after the response is returned, before the Worker is killed
47-
ctx.waitUntil(client.end());
48-
4950
return Response.json({
5051
success: true,
5152
result: result.rows,
5253
});
5354
} catch (error: any) {
5455
console.error("Database error:", error.message);
5556

56-
new Response('Internal error occurred', { status: 500 });
57+
new Response("Internal error occurred", { status: 500 });
5758
}
5859
},
5960
};

0 commit comments

Comments
 (0)