Skip to content

Commit cce882a

Browse files
Apply suggestions from code review
Co-authored-by: James Opstad <[email protected]>
1 parent b6997e2 commit cce882a

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

src/content/docs/workers/frameworks/framework-guides/hono.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ With Workers Assets, you can easily combine a Hono API running on Workers with a
6363
- `assets.not_found_handling` is set to `single-page-application`, which means that routes that are handled by your SPA do not go to the Worker, and are thus free.
6464
- If you want to add bindings to resources on Cloudflare's developer platform, you configure them here. Read more about [bindings](/workers/runtime-apis/bindings/).
6565

66-
`vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your Worker in Cloudflare's `workerd` runtime, ensuring your local development environment is as close to production as possible.
66+
`vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your Worker in the Cloudflare Workers runtime, ensuring your local development environment is as close to production as possible.
6767

6868
`src/worker/index.ts` is your Hono app, which contains a single endpoint to begin with, `/api`.
6969
At `src/react-app/src/App.tsx`, your React app calls this endpoint to get a message back and displays this in your SPA.
@@ -74,8 +74,8 @@ With Workers Assets, you can easily combine a Hono API running on Workers with a
7474
After creating your project, run the following command in your project directory to start a local development server.
7575
<PackageManagers type="run" args="dev" />
7676
<Details header="What's happening in local development?">
77-
This project uses Vite for local development and build, and thus comes with all of Vite's features like hot module replacement (HMR).
78-
In addition, `vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your application in Cloudflare's `workerd` runtime, just like in production, as well as access to local emulators of bindings.
77+
This project uses Vite for local development and build, and thus comes with all of Vite's features, including hot module replacement (HMR).
78+
In addition, `vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your application in the Cloudflare Workers runtime, just like in production, and enables access to local emulations of bindings.
7979
</Details>
8080

8181
3. **Deploy your project**

src/content/docs/workers/frameworks/framework-guides/react.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ import {
6262
- `assets.not_found_handling` is set to `single-page-application`, which means that routes that are handled by your React SPA do not go to the Worker, and are thus free.
6363
- If you want to add bindings to resources on Cloudflare's developer platform, you configure them here. Read more about [bindings](/workers/runtime-apis/bindings/).
6464

65-
`vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your Worker in Cloudflare's `workerd` runtime, ensuring your local development environment is as close to production as possible.
65+
`vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your Worker in the Cloudflare Workers runtime, ensuring your local development environment is as close to production as possible.
6666

67-
`worker/index.ts` is your backend API, which contains a single endpoint `/api` that returns a text response.
67+
`worker/index.ts` is your backend API, which contains a single endpoint, `/api/`, that returns a text response.
6868
At `src/App.tsx`, your React app calls this endpoint to get a message back and displays this.
6969
</Details>
7070

@@ -73,8 +73,8 @@ import {
7373
After creating your project, run the following command in your project directory to start a local development server.
7474
<PackageManagers type="run" args="dev" />
7575
<Details header="What's happening in local development?">
76-
This project uses Vite for local development and build, and thus comes with all of Vite's features like hot module replacement (HMR).
77-
In addition, `vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your application in Cloudflare's `workerd` runtime, just like in production, as well as access to local emulators of bindings.
76+
This project uses Vite for local development and build, and thus comes with all of Vite's features, including hot module replacement (HMR).
77+
In addition, `vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your application in the Cloudflare Workers runtime, just like in production, and enables access to local emulations of bindings.
7878
</Details>
7979

8080
3. **Deploy your project**

src/content/docs/workers/frameworks/framework-guides/vue.mdx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ To use `create-cloudflare` to create a new Vue project with <InlineBadge preset=
4949
- `assets.not_found_handling` is set to `single-page-application`, which means that routes that are handled by your Vue SPA do not go to the Worker, and are thus free.
5050
- If you want to add bindings to resources on Cloudflare's developer platform, you configure them here. Read more about [bindings](/workers/runtime-apis/bindings/).
5151

52-
`vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your Worker in Cloudflare's `workerd` runtime, ensuring your local development environment is as close to production as possible.
52+
`vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your Worker in the Cloudflare Workers runtime, ensuring your local development environment is as close to production as possible.
5353

54-
`server/index.ts` is your backend API, which contains a single endpoint `/api` that returns a text response.
54+
`server/index.ts` is your backend API, which contains a single endpoint, `/api/`, that returns a text response.
5555
At `src/App.vue`, your Vue app calls this endpoint to get a message back and displays this.
5656
</Details>
5757

@@ -62,10 +62,9 @@ After you have created your project, run the following command in the project di
6262
<PackageManagers type="run" args={"dev"} />
6363
<Details header="What's happening in local development?">
6464
This project uses Vite for local development and build, and thus comes with
65-
all of Vite's features like hot module replacement (HMR). In addition,
66-
`vite.config.ts` is set up to use the Cloudflare Vite plugin. This runs your
67-
application in Cloudflare's `workerd` runtime, just like in production, as
68-
well as access to local emulators of bindings.
65+
all of Vite's features, including hot module replacement (HMR). In addition,
66+
`vite.config.ts` is set up to use the Cloudflare Vite plugin.
67+
This runs your application in the Cloudflare Workers runtime, just like in production, and enables access to local emulations of bindings.
6968
</Details>
7069

7170
## 3. Deploy your project

0 commit comments

Comments
 (0)