enable prefer const rule, remove onetrust test

Author: KianNH

.github/workflows/publish-preview.yml

@@ -31,7 +31,6 @@ jobs:
         name: Build
         env:
           NODE_OPTIONS: --max-old-space-size=4096
-          CF_PAGES_BRANCH: production
       - run: npx wrangler pages deploy --project-name cloudflare-docs dist
         name: Deploy to Cloudflare Pages
         env:

bin/validate-redirects.ts

@@ -6,7 +6,8 @@ async function main() {
 	let numInfiniteRedirects = 0;
 	let numUrlsWithFragment = 0;
 	let numDuplicateRedirects = 0;
-	let redirectSourceUrls: string[] = [];
+
+	const redirectSourceUrls: string[] = [];
 
 	for (const line of redirects.split("\n")) {
 		if (line.startsWith("#") || line.trim() === "") continue;

eslint.config.js

@@ -30,7 +30,6 @@ export default [
 	},
 	{
 		rules: {
-			"prefer-const": "off",
 			"no-var": "error",
 			"@typescript-eslint/no-explicit-any": "off",
 			"@typescript-eslint/triple-slash-reference": "off",

src/components/FieldCatalog.tsx

@@ -41,7 +41,7 @@ const FieldCatalog = ({ fields }: { fields: Fields }) => {
 
 		if (filters.search) {
 			// search keywords
-			let keywordFound = field.keywords?.some(
+			const keywordFound = field.keywords?.some(
 				(kw) => kw.indexOf(filters.search) >= 0,
 			);
 

src/pages/search.astro

@@ -131,7 +131,7 @@ import "instantsearch.css/themes/satellite.css";
 
 		return (widgetParams: any) => {
 			const widget = makeWidget(widgetParams);
-			let state: {
+			const state: {
 				windowClickListener?: (event: MouseEvent) => void;
 			} = {};
 			let rootElem: HTMLElement | null;