-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Closed
Labels
DevRelTasks that need support from developer relations.Tasks that need support from developer relations.
Description
A couple of assumptions:
- When making an edit, starting from a consistently formatted page makes creating that edit easier.
- Not everyone is making these changes in an IDE with Prettier installed (e.g. GitHub online directly)
- We don't want to block edits which don't conform to formatting rules. We do want to allow them to be made without any additional friction.
- We don't love reviewing PRs which come from contributors which have an auto-formatter installed on their IDE, so inadvertently pull in unrelated formatting changes with their PRs.
- Consistent formatting is useful to both contributors, and to our readers (esp. for code snippets).
I propose making a (non-trivial) effort to run prettier --write across the codebase, and then, in order to maintain that consistency going forward, run prettier --write again on every merge atop the contributor's content commits. Couple of ways we could technically do this, and I don't really mind about the specifics. Just wanted to start the conversation here about actually trying to uphold some consistency here.
Cherry and Lerenah3
Metadata
Metadata
Assignees
Labels
DevRelTasks that need support from developer relations.Tasks that need support from developer relations.