add workers/frameworks and workers/static-assets code owner rules #17349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying cloudflare-docs with
|
| Latest commit: |
05a1236
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://246f11c4.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://dario-workers-frameworks-own.cloudflare-docs-7ou.pages.dev |
dario-piotrowicz
changed the title
KimJ15
approved these changes
Oct 7, 2024
elithrar
pushed a commit
that referenced
this pull request
Oct 15, 2024
…7349) * add the frameworks team members as code owners of the workers/frameworks directory * add tanushree-sharma to the framework-guides codeowners * add new codeowners rule for workers/static-assets * add walshy to the workers/static-assets code owners rule
maheshwarip
pushed a commit
that referenced
this pull request
Dec 2, 2024
…7349) * add the frameworks team members as code owners of the workers/frameworks directory * add tanushree-sharma to the framework-guides codeowners * add new codeowners rule for workers/static-assets * add walshy to the workers/static-assets code owners rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same folks that were code owners of the pages frameworks guides should also own the new workers frameworks guides, so I am adding such a rule
I'm also adding @tanushree-sharma as a code owner in case she's interested
Speaking of Tanushree, I've noticed that
workers/static-assetsdoesn't have a code owners rule, so I am also adding one