[Docs Site] Cache Astro assets in ci.yml #17487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
GregBrimble,
WalshyDev,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp and
pedrosousa
as code owners
github-actions
bot
assigned
GregBrimble,
haleycode,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa and
WalshyDev
haleycode
approved these changes
Oct 11, 2024
Deploying cloudflare-docs with
|
| Latest commit: |
83beabb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8f0b92eb.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-14089.cloudflare-docs-7ou.pages.dev |
Contributor
|
Pages just caches the entire
TIL. Good addition, GitHub! |
Member
Author
No particular reason! Currently Astro only caches assets between runs but with Astro 5 on the horizon there'll be more things in there related to incremental builds so I'll move it over to the whole folder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cache Astro assets (resized images) like we do in publish-production and publish-preview.
Explicit NPM cache step is unnecessary, v4 will handle this.