Rename Compatibility Dates to Compatibility Flags #18176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
requested review from
a team,
GregBrimble,
KianNH,
ToriLindsay,
WalshyDev,
haleycode,
irvinebroque,
kristianfreeman,
marciocloudflare,
maxvp,
mikenomitch and
pedrosousa
as code owners
2 tasks
github-actions
bot
assigned
dcpena,
haleycode,
patriciasantaana,
pedrosousa,
GregBrimble,
KianNH,
WalshyDev,
kristianfreeman,
marciocloudflare and
maxvp
Deploying cloudflare-docs with
|
| Latest commit: |
4d06ca1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://30f227f3.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://compatflags.cloudflare-docs-7ou.pages.dev |
Contributor
Contributor
Author
|
Checks:
/cc @ToriLindsay that should cover what we discussed offline. Thanks for the help. |
Rename: - Component: CompatibilityDates -> CompatibilityFlags - Files - Collection: compatibility-dates -> compatibility-flags - Schema: CompatibilityDatesSchema -> CompatibilityFlagsSchema Update: - CODEOWNERS - Redirect: https://developers.cloudflare.com/workers/platform/compatibility-dates.json -> compatibility-flags.json
Contributor
Author
|
rebased |
ToriLindsay
approved these changes
Nov 18, 2024
Contributor
ToriLindsay
left a comment
ToriLindsay
left a comment
There was a problem hiding this comment.
@vicb Thanks for confirming that everything works!
KianNH
approved these changes
Nov 18, 2024
Contributor
Author
|
Thanks for your help @ToriLindsay ! |
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
Rename: - Component: CompatibilityDates -> CompatibilityFlags - Files - Collection: compatibility-dates -> compatibility-flags - Schema: CompatibilityDatesSchema -> CompatibilityFlagsSchema Update: - CODEOWNERS - Redirect: https://developers.cloudflare.com/workers/platform/compatibility-dates.json -> compatibility-flags.json
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename:
Update:
Details
Follow up for #17900
The name "Compatibility Dates" probably comes from the fact that there was no "Compatibility Flags" section prior ro #17900. However the collection and the component list flags, not dates.
Documentation checklist