-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[worker] Document response stream disconnected error #18567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[worker] Document response stream disconnected error #18567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 total issue(s) found.
This change documents the `responseStreamDisconnected` error `outcome` seen in CloudFlare worker logs and error metrics. Previously, this outcome doesn't appear to be documented, but presents as an error in metrics and presents as a non-error entry in the CloudFlare Worker Logs. This change aims to reduce confusion going forward. Changes introducing `responseStreamDisconnected`: cloudflare/workerd#2503
c63fc4e to
ad090c0
Compare
|
Looks reasonable to me, FWIW. |
|
@jackatbancast @jclee |
|
@ToriLindsay thank you for the feedback and the suggestions. I'd initially considered adding this to the table mentioned, but I don't believe it quite fits there as we don't get an error message in the logs, instead getting an This being said, I'm not sure if this page is the best place for this content at all given that it is not an error log, but I thought it would be best to make it slightly more discoverable. I'm happy to defer to guidance on where this would be best placed. |
|
@jackatbancast Thanks for the context! |
|
@GregBrimble @jasnell Would either of you mind confirming that the location that I moved this info to in the docs makes sense? |
|
@ToriLindsay, thank you for making these changes. I was planning to pick this back up today after closing off other priorities. I think the change makes sense from my side, thank you for actioning your feedback. |
|
Congratulations @jackatbancast, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm7j96j4v78640cjvzqvqeoia This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |


Summary
This change documents the
responseStreamDisconnectedeventoutcomeseen in CloudFlare worker logs and error metrics.Previously, this outcome doesn't appear to be documented, but presents as an error in metrics and presents as a non-error entry in the CloudFlare Worker Logs. This change aims to reduce confusion going forward.
Changes introducing
responseStreamDisconnected: cloudflare/workerd#2503Documentation checklist