-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Removes Workers Sites docs, adds FAQ for Workers Static assets #19693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:
|
Deploying cloudflare-docs with
|
| Latest commit: |
9b28e92
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95e9c4f2.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://korinne-workers-sites.cloudflare-docs-7ou.pages.dev |
src/env.d.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file?
|
This lil guy is right, we should set up some redirects for those pages to Workers Assets in their place. |
Cherry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was Workers Sites ever officially deprecated by Cloudflare?
Removing docs for a functional product that still exists within wrangler today (and hasn't yet been deprecated there so will likely still exist in v4) seems a little hasty. Pushing people to Pages and Assets with messages at the top of docs makes sense, but removing them entirely seems heavy-handed to me, even if usage is low.
LLMs pointing people to use Sites is something that should be solved without removing docs for a still-functional product, in my opinion.
Co-authored-by: Greg Brimble <[email protected]>
…are-docs into korinne/workers-sites
|
@Cherry Hey! No, we haven't officially deprecated Workers Sites, though we have essentially no usage (we've been pushing people to Pages for some time, and Pages has garnered all the previous Workers Sites usage). While I'd typically agree that I don't like pulling docs down when something isn't officially deprecated, we checked our current usage and decided we were comfortable with the choice. If anyone finds this PR and happens to absolutely need the Workers Sites docs, please feel free to reach out to me directly at [email protected], and I can help you. Thanks for the callout @Cherry -- it's a super fair point. |
|
Thanks @korinne, I appreciate the thoughtful response. I feel that this sets a pretty dangerous precedent though. I myself have multiple Workers Sites projects in production, and Cloudflare's own official SDK Ideally, |
|
Since this product isn't deprecated yet, we shouldn't remove the docs completely. Can we instead block this page from crawlers so it's less findable (and LLMs don't crawl) but still available for folks who need it? |
|
Closing in favor of #19818 |
Summary
Documentation checklist