WIP: MCP #20860
WIP: MCP #20860
Conversation
github-actions
bot
added
product:agents
github-actions
bot
assigned
patriciasantaana,
pedrosousa,
elithrar,
harshil1712,
megaconfidence,
rita3ko,
thomasgauvin and
threepointone
irvinebroque
unassigned
harshil1712,
thomasgauvin,
dcpena,
haleycode,
patriciasantaana,
elithrar,
pedrosousa and
megaconfidence
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
| M->>C: MCP access token | ||
| ``` | ||
|
|
||
| Read the docs for the [Workers oAuth Provider Library](/agents/model-context-protocol/mcp-server/authorization/oauth-provider-api-reference/) for more details. |
There was a problem hiding this comment.
Identified issues
- Vale Style Guide - (Terms-error) Use 'OAuth' instead of 'oAuth'.
Proposed fix
| Read the docs for the [Workers oAuth Provider Library](/agents/model-context-protocol/mcp-server/authorization/oauth-provider-api-reference/) for more details. | |
| Read the docs for the [Workers OAuth Provider Library](/agents/model-context-protocol/mcp-server/authorization/oauth-provider-api-reference/) for more details. |
The term 'oAuth' should be capitalized as 'OAuth' to comply with the style guide. This change is outside of any code references or URLs, so it's appropriate to make this correction.
|
|
||
| ### (3) Bring your own OAuth Provider | ||
|
|
||
| If your application already implements an Oauth Provider itself, or you use Stytch, Auth0, or authorization-as-a-service provider, you can use this in the same way that you would use a third-party OAuth provider, described above in (2). |
There was a problem hiding this comment.
Identified issues
- Vale Style Guide - (Terms-error) Use 'OAuth' instead of 'Oauth'.
Proposed fix
| If your application already implements an Oauth Provider itself, or you use Stytch, Auth0, or authorization-as-a-service provider, you can use this in the same way that you would use a third-party OAuth provider, described above in (2). | |
| If your application already implements an OAuth Provider itself, or you use Stytch, Auth0, or authorization-as-a-service provider, you can use this in the same way that you would use a third-party OAuth provider, described above in (2). |
I corrected the capitalization of 'Oauth' to 'OAuth' as per the style guide recommendation. This change does not affect any code references or URLs.
|
|
||
| For example, the following code defines a simple MCP server that adds two numbers together: | ||
|
|
||
| {/* TODO: Reference code in Github, link to a runnable example, use Deploy to Workers button */} |
There was a problem hiding this comment.
Identified issues
- Vale Style Guide - (Terms-error) Use 'GitHub' instead of 'Github'.
Proposed fix
| {/* TODO: Reference code in Github, link to a runnable example, use Deploy to Workers button */} | |
| {/* TODO: Reference code in GitHub, link to a runnable example, use Deploy to Workers button */} |
I corrected the capitalization of 'Github' to 'GitHub' as it was a straightforward capitalization issue not within any restricted context.
| * Define public methods on your Worker that can be called by other Workers on the same Cloudflare account, via [Service Bindings](/workers/runtime-apis/bindings/service-bindings/rpc) | ||
| * Define public methods on [Durable Objects](/durable-objects) that can be called by other workers on the same Cloudflare account that declare a binding to it. | ||
| - Define public methods on your Worker that can be called by other Workers on the same Cloudflare account, via [Service Bindings](/workers/runtime-apis/bindings/service-bindings/rpc) | ||
| - Define public methods on [Durable Objects](/durable-objects) that can be called by other workers on the same Cloudflare account that declare a binding to it. |
There was a problem hiding this comment.
Identified issues
- Vale Style Guide - (Terms-error) Use 'Workers' instead of 'workers'.
Proposed fix
| - Define public methods on [Durable Objects](/durable-objects) that can be called by other workers on the same Cloudflare account that declare a binding to it. | |
| - Define public methods on [Durable Objects](/durable-objects) that can be called by other Workers on the same Cloudflare account that declare a binding to it. |
I capitalized 'Workers' as per the style guide recommendation. This change does not affect any code references or special syntax.
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryIntroduced the Model Context Protocol (MCP) documentation with several new sections and examples related to MCP Servers and Clients.
Modified Files
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add What is Hyperlint?Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation. |
|
CI run failed: build logs |
| ``` | ||
|
|
||
| {/* TODO: Update code link */} | ||
| This will ensure that your users are redirected to GitHub to authenticate. If you're curious to understand what the `GitHubHandler` does you can read the code [here](https://github.com/geelen/mcp-remote-examples/blob/main/04-oauth-pivot/src/index.ts#L48-L152). |
There was a problem hiding this comment.
Identified issues
- Vale Style Guide - (cloudflare.MeaningfulLinkWords-warning) Warning: Rewrite the link text for
[here](https://github.com/geelen/mcp-remote-examples/blob/main/04-oauth-pivot/src/index.ts#L48-L152)to be more descriptive. For more information, refer to Descriptive link text.
Proposed fix
| This will ensure that your users are redirected to GitHub to authenticate. If you're curious to understand what the `GitHubHandler` does you can read the code [here](https://github.com/geelen/mcp-remote-examples/blob/main/04-oauth-pivot/src/index.ts#L48-L152). | |
| This will ensure that your users are redirected to GitHub to authenticate. If you're curious to understand what the `GitHubHandler` does you can read the code in the [GitHubHandler source code](https://github.com/geelen/mcp-remote-examples/blob/main/04-oauth-pivot/src/index.ts#L48-L152). |
The link text 'here' is not descriptive. I've replaced it with 'GitHubHandler source code' to provide more context about the link's destination.
14 participants
WIP do not merge