Skip to content

Non-production branch builds, GitHub comments and preview URLs #21383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

Non-production branch builds, GitHub comments and preview URLs #21383

merged 2 commits into from
Apr 7, 2025

Conversation

@GregBrimble
Copy link
Contributor

@GregBrimble GregBrimble commented Apr 3, 2025

Summary

Documents the new options for non-production builds. Hold until Monday evening.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 3, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Documented new options for non-production builds, including GitHub comments and preview URLs.

  • Added documentation for configuring non-production branch builds.
  • Introduced GitHub pull request comments with build status updates and preview URLs.
  • Updated deployment commands to include non-production branch options.

Modified Files

  • src/content/docs/workers/ci-cd/builds/advanced-setups.mdx
  • src/content/docs/workers/ci-cd/builds/build-watch-paths.mdx
  • src/content/docs/workers/ci-cd/builds/configuration.mdx
  • src/content/docs/workers/ci-cd/builds/git-integration/github-integration.mdx
  • src/content/docs/workers/ci-cd/builds/git-integration/gitlab-integration.mdx
  • src/content/docs/workers/ci-cd/builds/git-integration/index.mdx
  • src/content/docs/workers/ci-cd/builds/limits-and-pricing.mdx
  • src/content/docs/workers/ci-cd/builds/troubleshoot.mdx

Added Files

  • src/content/docs/workers/ci-cd/builds/build-branches.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions github-actions bot added product:workers Related to Workers product size/m labels Apr 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025 •
edited
Loading

Preview URL: https://3ba44299.preview.developers.cloudflare.com
Preview Branch URL: https://preview-urls.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers/ci-cd/builds/configuration/ https://preview-urls.preview.developers.cloudflare.com/workers/ci-cd/builds/configuration/
https://developers.cloudflare.com/workers/ci-cd/builds/limits-and-pricing/ https://preview-urls.preview.developers.cloudflare.com/workers/ci-cd/builds/limits-and-pricing/
https://developers.cloudflare.com/workers/ci-cd/builds/build-branches/ https://preview-urls.preview.developers.cloudflare.com/workers/ci-cd/builds/build-branches/
https://developers.cloudflare.com/workers/ci-cd/builds/git-integration/github-integration/ https://preview-urls.preview.developers.cloudflare.com/workers/ci-cd/builds/git-integration/github-integration/
https://developers.cloudflare.com/workers/ci-cd/builds/git-integration/gitlab-integration/ https://preview-urls.preview.developers.cloudflare.com/workers/ci-cd/builds/git-integration/gitlab-integration/
https://developers.cloudflare.com/workers/ci-cd/builds/advanced-setups/ https://preview-urls.preview.developers.cloudflare.com/workers/ci-cd/builds/advanced-setups/
https://developers.cloudflare.com/workers/ci-cd/builds/git-integration/ https://preview-urls.preview.developers.cloudflare.com/workers/ci-cd/builds/git-integration/
https://developers.cloudflare.com/workers/ci-cd/builds/build-watch-paths/ https://preview-urls.preview.developers.cloudflare.com/workers/ci-cd/builds/build-watch-paths/
https://developers.cloudflare.com/workers/ci-cd/builds/troubleshoot/ https://preview-urls.preview.developers.cloudflare.com/workers/ci-cd/builds/troubleshoot/

@kodster28
Copy link
Collaborator

kodster28 commented Apr 3, 2025

@GregBrimble, adding this to my queue for tomorrow!

kodster28
kodster28 reviewed Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@kodster28 kodster28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly looked over + looks good. Can provide a more detailed review + approval if you need it. Just let me know

@GregBrimble
Copy link
Contributor Author

GregBrimble commented Apr 4, 2025

Approval, yes please! More detailed review, if you've got the time! Suggestions for any improvements are more than welcome :)

kodster28
kodster28 approved these changes Apr 7, 2025
View reviewed changes
korinne
korinne approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@korinne korinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great -- thank you Greg!

@korinne korinne merged commit 9d05db2 into production Apr 7, 2025
11 checks passed
@korinne korinne deleted the preview-urls branch April 7, 2025 22:53
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
@GregBrimble @kodster28 @RebeccaTamachiro
Non-production branch builds, GitHub comments and preview URLs (#21383)
4d34407 
* Preview URLs

* Apply suggestions from code review

Co-authored-by: Kody Jackson <[email protected]>

---------

Co-authored-by: Kody Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irvinebroque irvinebroque irvinebroque approved these changes

@kodster28 kodster28 kodster28 approved these changes

@korinne korinne korinne approved these changes

@aninibread aninibread Awaiting requested review from aninibread aninibread is a code owner

@ToriLindsay ToriLindsay Awaiting requested review from ToriLindsay

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

Assignees

@irvinebroque irvinebroque

@WalshyDev WalshyDev

@korinne korinne

@aninibread aninibread

@ToriLindsay ToriLindsay

Labels

blocked product:workers Related to Workers product size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GregBrimble @kodster28 @irvinebroque @korinne @WalshyDev @aninibread @ToriLindsay