-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[workers] Update vitest getting started guide #21454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated the Vitest getting started guide to enhance clarity and usability for users testing Workers.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
edmundhung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the improvements! Just a few minor nitpicks, but nothing's blocking. 👍🏼
| sidebar: | ||
| order: 1 | ||
| group: | ||
| hideIndex: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like most of this pages is moved to the overview of the vitest-integration. Should we redirect people to the overview page instead of keeping a duplicate here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you need an index.mdx at every level, so we can't get rid of it entirely, just hide it like this. Would love to though if you know how!
I also plan to move some pages around so its not so nested, but that PR was getting super confusing to review so i'm going to do content updates here first, then move pages around.
src/content/docs/workers/testing/vitest-integration/get-started/write-your-first-test.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/testing/vitest-integration/get-started/write-your-first-test.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/testing/vitest-integration/get-started/write-your-first-test.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/testing/vitest-integration/get-started/write-your-first-test.mdx
Outdated
Show resolved
Hide resolved
|
thanks for the spot on feedback @edmundhung 🎉 |
d1ebe76 to
6b721d8
Compare
* update write your first test * tidy up various overviews * pr feedback
Summary
Screenshots (optional)
Documentation checklist