Skip to content

Replace Remix framework guide with new React Router framework guide #21471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 7, 2025
Merged

Replace Remix framework guide with new React Router framework guide #21471

merged 14 commits into from
Apr 7, 2025

Conversation

@jamesopstad
Copy link
Contributor

@jamesopstad jamesopstad commented Apr 7, 2025 •
edited
Loading

Summary

Replace Remix framework guide with new React Router framework guide.

This follows the style for framework guides set in #21367.

closes #18997

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 7, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Replaced the Remix framework guide with a new guide for the React Router framework, enhancing documentation for creating and deploying applications using React Router on Cloudflare Workers.

  • Introduced a new guide for React Router framework applications.
  • Updated references in existing documentation to include the new React Router guide.
  • Added a section on using bindings with React Router for better integration with Cloudflare services.

Modified Files

  • src/content/docs/workers/vite-plugin/get-started.mdx
  • src/content/docs/workers/vite-plugin/index.mdx
  • src/content/docs/workers/vite-plugin/reference/cloudflare-environments.mdx

Added Files

  • src/content/docs/workers/frameworks/framework-guides/react-router.mdx
  • src/content/partials/workers/frameworks-bindings.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:

  • /workers/frameworks/framework-guides/remix/

@github-actions github-actions bot added the size/m label Apr 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025 •
edited
Loading

Preview URL: https://a54de209.preview.developers.cloudflare.com
Preview Branch URL: https://james-react-router.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers/frameworks/framework-guides/react-router/ https://james-react-router.preview.developers.cloudflare.com/workers/frameworks/framework-guides/react-router/
https://developers.cloudflare.com/workers/frameworks/framework-guides/remix/ https://james-react-router.preview.developers.cloudflare.com/workers/frameworks/framework-guides/remix/
https://developers.cloudflare.com/workers/vite-plugin/ https://james-react-router.preview.developers.cloudflare.com/workers/vite-plugin/
https://developers.cloudflare.com/workers/vite-plugin/reference/cloudflare-environments/ https://james-react-router.preview.developers.cloudflare.com/workers/vite-plugin/reference/cloudflare-environments/
https://developers.cloudflare.com/workers/vite-plugin/get-started/ https://james-react-router.preview.developers.cloudflare.com/workers/vite-plugin/get-started/

@github-actions github-actions bot added the product:workers Related to Workers product label Apr 7, 2025
korinne
korinne approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@korinne korinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

kodster28
kodster28 approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@kodster28 kodster28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Content + CLI setup tested and LGTM.

Just added a few cross links.

@korinne korinne enabled auto-merge (squash) April 7, 2025 19:18
@korinne korinne merged commit 9a699c3 into production Apr 7, 2025
11 checks passed
@korinne korinne deleted the james/react-router branch April 7, 2025 21:54
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
@jamesopstad @korinne
@kodster28 @RebeccaTamachiro
Replace Remix framework guide with new React Router framework guide (#…
ef86d05 
…21471)

* Create React Router framework page

* Update React Router framework page

* Add frameworks-bindings partial

* Remove Remix guide

* Tweaks

* Add links to React Router framework guide from Vite plugin docs

* Vite docs tweaks

* Add file names to .env file examples

* Remove unused components

* Add redirect

* Update src/content/docs/workers/frameworks/framework-guides/react-router.mdx

Co-authored-by: Kody Jackson <[email protected]>

* Update src/content/docs/workers/frameworks/framework-guides/react-router.mdx

Co-authored-by: Kody Jackson <[email protected]>

* Update src/content/docs/workers/frameworks/framework-guides/react-router.mdx

Co-authored-by: Kody Jackson <[email protected]>

---------

Co-authored-by: korinne <[email protected]>
Co-authored-by: Kody Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kodster28 kodster28 kodster28 approved these changes

@korinne korinne korinne approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

@aninibread aninibread Awaiting requested review from aninibread

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@ToriLindsay ToriLindsay Awaiting requested review from ToriLindsay

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

@mikenomitch mikenomitch Awaiting requested review from mikenomitch mikenomitch is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@KianNH KianNH Awaiting requested review from KianNH

@pedrosousa pedrosousa Awaiting requested review from pedrosousa

Assignees

@IgorMinar IgorMinar

@irvinebroque irvinebroque

@mikenomitch mikenomitch

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@aninibread aninibread

@ToriLindsay ToriLindsay

Labels

product:workers Related to Workers product size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migration / Update of Remix Guide to React Router?

10 participants

@jamesopstad @kodster28 @korinne @IgorMinar @irvinebroque @mikenomitch @GregBrimble @WalshyDev @aninibread @ToriLindsay