Skip to content

Conversation

@Oxyjun
Copy link
Contributor

@Oxyjun Oxyjun commented Apr 28, 2025

Summary

  1. Added "When does a Durable Object incur duration charges?" to the Billing FAQ.
  2. Minimally reworded a footnote in the Compute billing footnote, which now references the newly added FAQ heading.
  3. Removed glossary term "request context" from DO glossary (until we can come up with a more accurate explanation).
  4. Removed GlossaryTooltip from pointing to the deleted "request context" definition.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Removing glossary term for request context until
later.
@github-actions github-actions bot added size/s product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ labels Apr 28, 2025
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 28, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated Durable Object documentation with new billing information and glossary adjustments.

  • Added a section on duration charges for Durable Objects in the Billing FAQ.
  • Reworded a footnote in the Compute billing section to reference the new FAQ.
  • Removed the glossary term 'request context' and its associated tooltip.

Modified Files

  • src/content/docs/durable-objects/api/state.mdx
  • src/content/docs/durable-objects/platform/pricing.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@Oxyjun
Copy link
Contributor Author

Oxyjun commented Apr 29, 2025

@joshthoward @vy-ton could I get your eyes on this before merging?

Copy link
Contributor

@vy-ton vy-ton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plan to review this today

@Oxyjun
Copy link
Contributor Author

Oxyjun commented May 28, 2025

Commenting relevant thread from a previous PR

#20938 (comment)

@Oxyjun Oxyjun requested a review from mikenomitch as a code owner June 24, 2025 13:31
@github-actions
Copy link
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/durable-objects/ @elithrar, @vy-ton, @joshthoward, @oxyjun, @harshil1712, @mikenomitch, @cloudflare/pcx-technical-writing, @cloudflare/workers-runtime-1
* @cloudflare/pcx-technical-writing

Copy link
Contributor

@vy-ton vy-ton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

@Oxyjun Oxyjun enabled auto-merge (squash) June 26, 2025 10:57
@Oxyjun Oxyjun merged commit 25675c2 into production Jun 26, 2025
11 checks passed
@Oxyjun Oxyjun deleted the jun/do/billing-do-lifecycle-details branch June 26, 2025 11:08
sdnts pushed a commit to sdnts/cloudflare-docs that referenced this pull request Jul 24, 2025
* Adding explanation on duration billing of a DO.
Removing glossary term for request context until
later.

* Implementing feedback from Frederik

* Updating wording

* Apply suggestions from code review

Co-authored-by: Vy Ton <[email protected]>

---------

Co-authored-by: Vy Ton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants