Skip to content

Conversation

@ranbel
Copy link
Contributor

@ranbel ranbel commented May 8, 2025

PCX-12683

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented May 8, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Enhanced the Local Domain Fallback documentation with new instructions and examples for adding domains and configuring DNS servers.

  • Added a new section for adding domains to the Local Domain Fallback list with detailed steps.
  • Introduced Terraform configuration examples for Local Domain Fallback.
  • Updated existing documentation to reference the new domain addition process.

Modified Files

  • src/content/docs/cloudflare-one/connections/connect-devices/warp/configure-warp/route-traffic/local-domains.mdx
  • src/content/partials/cloudflare-one/warp/view-local-domains.mdx
  • src/content/partials/learning-paths/zero-trust/private-dns.mdx

Added Files

  • src/content/partials/cloudflare-one/warp/add-local-domain.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@ranbel ranbel merged commit 14241cd into production May 9, 2025
12 checks passed
@ranbel ranbel deleted the ranbel/terraform-local-domain-fallback branch May 9, 2025 15:45
daisyfaithauma pushed a commit that referenced this pull request May 13, 2025
* local domain fallback

* Apply suggestions from code review

Co-authored-by: Pedro Sousa <[email protected]>

---------

Co-authored-by: Pedro Sousa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants