-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Add Next.js features support #22421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Next.js features support #22421
Conversation
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryEnhanced Next.js documentation to include support details for various features in the Cloudflare OpenNext adapter.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://a82ba38f.preview.developers.cloudflare.com Files with changes (up to 15) |
kodster28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also recommend adding links to each feature in NextJS?
src/content/docs/workers/frameworks/framework-guides/nextjs.mdx
Outdated
Show resolved
Hide resolved
| | Image optimization | 🟢 supported | Supported via [Cloudflare Images](https://developers.cloudflare.com/images/) | | ||
| | Partial Prerendering (PPR) | 🟢 supported | PPR is experimental in Next.js | | ||
| | Composable Caching ('use cache') | 🟢 supported | Composable Caching is experimental in Next.js | | ||
| | Node.js in Middleware | ⚪ not yet supported | Node.js middleware introduced in 15.2 are not yet supported | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should maybe format to be more like https://developers.cloudflare.com/data-localization/compatibility/ throughout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I based the format on https://developers.cloudflare.com/workers/runtime-apis/nodejs/#supported-nodejs-apis but I agree that a documented/consistent format across the site would be better idea
Co-authored-by: Kody Jackson <[email protected]>
I thought about that (we do have links on opennext.js.org/cloudflare) But decided otherwise here:
But I dont't have a strong opinion, can be convinced to add them! |
Makes sense to me! You know the audience here better than I do. |
|
@kodster28 Thanks for the feedback. I am going to merge as is for now. |
Co-authored-by: Kody Jackson <[email protected]>
Summary
Screenshots (optional)
Documentation checklist