-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Update response-buffering.mdx #22976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 To request another review, post a new comment with "/windsurf-review".
| ## How it works | ||
|
|
||
| By default, Cloudflare **streams** traffic data, meaning that each packet is sent as it becomes available. This can improve the delivery of large files. However, this streaming behavior only applies to dynamic traffic; cacheable traffic is buffered and this behavior cannot be changed. | ||
| By default, Cloudflare **streams** traffic data, meaning that each packet is sent as it becomes available. This can improve the delivery of large files. However, this streaming behavior only applies to dynamic traffic; cacheable traffic (that is, *any* status noted in [Cloudflare cache responses](https://developers.cloudflare.com/cache/concepts/cache-responses/) with the exception of **DYNAMIC**) is buffered and this behavior cannot be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added clarification is helpful, but consider using consistent formatting for emphasis. Currently you're using both italics and bold in the same parenthetical. Consider using bold formatting consistently:
| By default, Cloudflare **streams** traffic data, meaning that each packet is sent as it becomes available. This can improve the delivery of large files. However, this streaming behavior only applies to dynamic traffic; cacheable traffic (that is, *any* status noted in [Cloudflare cache responses](https://developers.cloudflare.com/cache/concepts/cache-responses/) with the exception of **DYNAMIC**) is buffered and this behavior cannot be changed. | |
| By default, Cloudflare **streams** traffic data, meaning that each packet is sent as it becomes available. This can improve the delivery of large files. However, this streaming behavior only applies to dynamic traffic; cacheable traffic (that is, **any** status noted in [Cloudflare cache responses](https://developers.cloudflare.com/cache/concepts/cache-responses/) with the exception of **DYNAMIC**) is buffered and this behavior cannot be changed. |
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryClarified the behavior of cacheable traffic in the response buffering documentation.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
Congratulations @dpolaske-cloudflare, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmbs7saz1392907kzh3hxrich This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
* Update response-buffering.mdx https://jira.cfdata.org/browse/CUSTESC-52250 * Tiny formatting fix --------- Co-authored-by: Denise Peña <[email protected]>
https://jira.cfdata.org/browse/CUSTESC-52250
Summary
Screenshots (optional)
Documentation checklist