Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Jun 28, 2025

@mikenomitch Thanks for #20642, nice to see some docs for that. Maybe we could add a few more details from @jasnell #19187 and close it?

One thing that is missing from the current doc and I mention on James's PR is importable env and how it interacts with process.env. I'll create a new issue here to track that

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Jun 28, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Made minor fixes related to process.env documentation and improved clarity in examples.

  • Corrected typos in the documentation regarding Java compatibility flags for Spark.
  • Clarified the explanation of process.env in the Node.js implementation.
  • Updated compatibility flag references for better accuracy.

Modified Files

  • src/content/docs/r2/data-catalog/config-examples/spark-scala.mdx
  • src/content/docs/workers/runtime-apis/nodejs/process.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/changelog/ @cloudflare/pm-changelogs, @cloudflare/pcx-cloudflare-one
/src/content/compatibility-flags/ @irvinebroque, @mikenomitch, @GregBrimble, @cloudflare/pcx-technical-writing
/src/content/docs/r2/ @oxyjun, @elithrar, @jonesphillip, @aninibread, @harshil1712, @cloudflare/workers-docs, @cloudflare/pcx-technical-writing
/src/content/docs/workers/ @cloudflare/workers-docs, @GregBrimble, @irvinebroque, @mikenomitch, @korinne, @WalshyDev, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing, @kodster28, @cloudflare/wrangler, @cloudflare/workers-runtime-1, @cloudflare/wrangler

@vicb vicb merged commit 32b7455 into production Jul 8, 2025
12 checks passed
@vicb vicb deleted the vicb/process-env branch July 8, 2025 08:09
sdnts pushed a commit to sdnts/cloudflare-docs that referenced this pull request Jul 24, 2025
thomasgauvin pushed a commit that referenced this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:r2 R2 object storage: https://developers.cloudflare.com/r2 product:workers Related to Workers product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.