[doc] Python worker doc dict fix #23716
Conversation
1. updated from string.format() to f-strings (supported since python 3.6) 2. Updated examples to be internally consistent: the params example was referencing the dict element directly whereas the json example was setting a variable from the dict 3. Updated json example to fix dicts in python do not use dot notation and reference the key instead.
correct spacing for new line int parameters example
1. in hello function, update to use f-string for return instead of concatenating strings with plus symbol 2. in POST example, fix dict reference to use key as dicts do not support dot notation by default
sjsadowski
requested review from
a team,
GregBrimble,
WalshyDev,
irvinebroque,
kodster28,
korinne and
mikenomitch
as code owners
github-actions
bot
assigned
GregBrimble,
irvinebroque,
kodster28,
korinne,
mikenomitch and
WalshyDev
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated Python worker documentation to improve code examples and ensure compatibility with Python 3.6 and above.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
|
closing this PR, may reopen - I have now been using python workers in two different setups and I'm getting inconsistent results with the dot notation; on one machine running under wrangler dev (await request.json)["key"] works and on another it does not, but the documented (await request.json()).key works. Will open a new request once this is resolved with the correct updates. |
7 participants
Summary
Python worker examples used dot notation for json objects converted to dicts, which doesn't work out of the box. In order to keep the examples simple, changed dot notation to key notation. Also removed string concatenation using plus signs and string.format() to both be f-strings as the current releases of pyodide all target support for python > 3.6
Documentation checklist