Skip to content

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Jul 21, 2025

@github-actions github-actions bot added product:workers Related to Workers product size/s labels Jul 21, 2025
@github-actions
Copy link
Contributor

This PR requires additional review attention because it affects the following areas:

Partials

This PR updates partial files, which are pieces of content used across multiple files in our Render component.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/workers/ @cloudflare/workers-docs, @GregBrimble, @irvinebroque, @mikenomitch, @korinne, @WalshyDev, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing, @kodster28, @cloudflare/wrangler, @cloudflare/workers-runtime-1, @cloudflare/wrangler
/src/content/docs/workers/wrangler/ @cloudflare/wrangler, @irvinebroque, @kodster28, @cloudflare/pcx-technical-writing, @cloudflare/workers-runtime-1
/src/content/partials/workers/ @cloudflare/workers-docs, @GregBrimble, @irvinebroque, @mikenomitch, @WalshyDev, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing, @kodster28, @cloudflare/wrangler, @cloudflare/workers-runtime-1, @cloudflare/wrangler

@korinne
Copy link
Contributor

korinne commented Jul 29, 2025

@petebacondarwin I think this page needs to get updated as well: https://developers.cloudflare.com/workers/development-testing/environment-variables/

@petebacondarwin petebacondarwin force-pushed the pbd/wrangler/dotenv branch 2 times, most recently from 08568e5 to a687114 Compare July 30, 2025 15:56
@petebacondarwin petebacondarwin marked this pull request as ready for review July 30, 2025 16:31
Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to take a pass here, existing docs we are building off are a bit too focused on edge cases vs. making this simple and then getting to the other stuff

@petebacondarwin
Copy link
Contributor Author

I would like to take a pass here, existing docs we are building off are a bit too focused on edge cases vs. making this simple and then getting to the other stuff

Discussed offline. We are going to land this as-is and then @irvinebroque can take a stab a refactoring the docs later.

@petebacondarwin petebacondarwin enabled auto-merge (squash) August 8, 2025 16:06
@petebacondarwin petebacondarwin merged commit 7c99879 into production Aug 8, 2025
8 checks passed
@petebacondarwin petebacondarwin deleted the pbd/wrangler/dotenv branch August 8, 2025 16:08
thomasgauvin pushed a commit that referenced this pull request Aug 15, 2025
* Document the new .env support for local development

* fixup! Document the new .env support for local development

* fixup! Document the new .env support for local development

* update development-testing/environment-variables page

* fix caution box title

* update vite-plugin page

* update system environment variables page

* clarify env vars that control handling

---------

Co-authored-by: kodster28 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants