Skip to content

Remove extraneous needs: test from GitHub Actions example in “External CI/CD” docs #23994

@prdai

Description

@prdai

Existing documentation URL(s)

https://developers.cloudflare.com/workers/ci-cd/external-cicd/github-actions/

(the “GitHub Actions” page under CI/CD → External CI/CD in the Workers docs)

What changes are you suggesting?

On the “Build & Deploy Worker” snippet (under the deploy job) you’ll see:

jobs:
  deploy:
    runs-on: ubuntu-latest
    timeout-minutes: 60
    needs: test    # ← this line
    steps:
      - uses: actions/checkout@v4
      - name: Build & Deploy Worker
        uses: cloudflare/wrangler-action@v3
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
  • Problem: There is no test job defined anywhere on this page, so needs: test is a dangling dependency.
  • Impact: Copy‑pasting this workflow will fail, and readers spend time hunting for a non‑existent job.

Suggested fix:

  • Remove the needs: test line entirely
  • (Alternatively, if you really want a test step, add a minimal test job above deploy so the example resolves)

Why should the docs be changed?

  • Ensures the example works out of the box
  • Eliminates confusing, broken references
  • Upholds clarity and trust in Cloudflare’s documentation

Additional information

No response

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions