-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Closed
Labels
content:editRequest for content editsRequest for content editsdocumentationDocumentation editsDocumentation editsproduct:workersRelated to Workers productRelated to Workers product
Description
Existing documentation URL(s)
https://developers.cloudflare.com/workers/ci-cd/external-cicd/github-actions/
(the “GitHub Actions” page under CI/CD → External CI/CD in the Workers docs)
What changes are you suggesting?
On the “Build & Deploy Worker” snippet (under the deploy job) you’ll see:
jobs:
deploy:
runs-on: ubuntu-latest
timeout-minutes: 60
needs: test # ← this line
steps:
- uses: actions/checkout@v4
- name: Build & Deploy Worker
uses: cloudflare/wrangler-action@v3
with:
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}- Problem: There is no
testjob defined anywhere on this page, soneeds: testis a dangling dependency. - Impact: Copy‑pasting this workflow will fail, and readers spend time hunting for a non‑existent job.
Suggested fix:
- Remove the
needs: testline entirely - (Alternatively, if you really want a test step, add a minimal
testjob abovedeployso the example resolves)
Why should the docs be changed?
- Ensures the example works out of the box
- Eliminates confusing, broken references
- Upholds clarity and trust in Cloudflare’s documentation
Additional information
No response
Metadata
Metadata
Labels
content:editRequest for content editsRequest for content editsdocumentationDocumentation editsDocumentation editsproduct:workersRelated to Workers productRelated to Workers product