Skip to content

Conversation

@ranbel
Copy link
Contributor

@ranbel ranbel commented Aug 27, 2024

PCX-10781
PCX-11533
PCX-13625

Replaces #15454

@gitguardian
Copy link

gitguardian bot commented Aug 27, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11021221 Triggered Generic High Entropy Secret bbfe9a8 astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret bbfe9a8 astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret bbfe9a8 astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret 30e5cef astro.config.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 27, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6d5a0df
Status: ✅  Deploy successful!
Preview URL: https://ff3b2a75.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://ranbel-warp-connector-2.cloudflare-docs-7ou.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/private-net/warp-connector/ https://ranbel-warp-connector-2.cloudflare-docs-7ou.pages.dev/cloudflare-one/connections/connect-networks/private-net/warp-connector/
https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/private-net/warp-connector/site-to-site/ https://ranbel-warp-connector-2.cloudflare-docs-7ou.pages.dev/cloudflare-one/connections/connect-networks/private-net/warp-connector/site-to-site/
https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/private-net/warp-connector/user-to-site/ https://ranbel-warp-connector-2.cloudflare-docs-7ou.pages.dev/cloudflare-one/connections/connect-networks/private-net/warp-connector/user-to-site/
https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/private-net/warp-connector/site-to-internet/ https://ranbel-warp-connector-2.cloudflare-docs-7ou.pages.dev/cloudflare-one/connections/connect-networks/private-net/warp-connector/site-to-internet/
https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/private-net/warp-connector/ https://ranbel-warp-connector-2.cloudflare-docs-7ou.pages.dev/cloudflare-one/connections/connect-networks/private-net/warp-connector/
https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/private-net/warp-connector/vpc-deployments/ https://ranbel-warp-connector-2.cloudflare-docs-7ou.pages.dev/cloudflare-one/connections/connect-networks/private-net/warp-connector/vpc-deployments/

@github-actions github-actions bot added size/l and removed size/m labels Oct 2, 2024
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 1 total issue(s) found.

@github-actions github-actions bot removed the size/l label Oct 4, 2024
@github-actions
Copy link
Contributor

This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:

  • /cloudflare-one/connections/connect-networks/private-net/warp-connector/

@ranbel ranbel enabled auto-merge (squash) October 16, 2024 17:42
@ranbel ranbel merged commit c806794 into production Oct 16, 2024
13 checks passed
@ranbel ranbel deleted the ranbel/warp-connector-2 branch October 16, 2024 17:55

</Details>

Cloudflare WARP Connector is a piece of software [^1] that enables site-to-site, bidirectional, and mesh networking connectivity without requiring changes to underlying network routing infrastructure. WARP Connector establishes a secure Layer 3 connection between a private network and Cloudflare, allowing you to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: A "connection" usually implies a persistent, stateful link between two endpoints and is typically managed at the transport layer (Layer 4) over TCP. It's a little odd to see connection and Layer 3 in the same sentence, but let's get more feedback there. I might be overanalyzing.

I'd also update piece of software to be more descriptive. Maybe software client?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abelinkinbio, does the following make more sense? WARP Connector establishes a secure Layer 3 proxy between a private network and Cloudflare

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I think switching to software agent and secure Layer 3 proxy makes sense


![Two subnets connected with WARP Connector](~/assets/images/cloudflare-one/connections/connect-apps/warp-connector/overview.png)

As shown in the diagram, WARP Connector acts as a router for a subnet within the private network to on-ramp and off-ramp traffic through Cloudflare. All devices on the subnet can access any services connected to Cloudflare, and all devices connected to Cloudflare can access any services on the subnet. Each subnet runs a WARP Connector on a designated Linux machine (typically the default gateway router), but other devices on the network do not need to install software.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link "typical the default gateway router" to the section in our tutorial which shows the two models you could run warp connector in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in #17793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants