Skip to content

Conversation

@angelampcosta
Copy link
Contributor

Summary

Adds google tag in first-party mode

Documentation checklist

@angelampcosta angelampcosta requested a review from a team as a code owner October 7, 2024 13:25
@gitguardian
Copy link

gitguardian bot commented Oct 7, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11021221 Triggered Generic High Entropy Secret f667b9a src/content/products/google-tag-first-party-mode.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 7, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 10531ac
Status: ✅  Deploy successful!
Preview URL: https://cb7a8cc9.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://angela-add-google-tag.cloudflare-docs-7ou.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

@angelampcosta angelampcosta merged commit dced53d into production Oct 7, 2024
12 of 14 checks passed
@angelampcosta angelampcosta deleted the angela/add-google-tag branch October 7, 2024 14:31
elithrar pushed a commit that referenced this pull request Oct 15, 2024
* Add Google tag first party mode

* Changes after review.

* Substitutes images.
maheshwarip pushed a commit that referenced this pull request Dec 2, 2024
* Add Google tag first party mode

* Changes after review.

* Substitutes images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants